Add type to Access applications

[Justin-Holmes]

Supports the type field for Access applications.

Requires cloudflare/cloudflare-go#646 before this can be merged.

[jacobbednarz]

CI is green

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareAccessApplication" -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareAccessApplicationBasic
--- PASS: TestAccCloudflareAccessApplicationBasic (8.31s)
=== RUN   TestAccCloudflareAccessApplicationWithCORS
--- PASS: TestAccCloudflareAccessApplicationWithCORS (3.69s)
=== RUN   TestAccCloudflareAccessApplicationWithAutoRedirectToIdentity
--- PASS: TestAccCloudflareAccessApplicationWithAutoRedirectToIdentity (3.68s)
=== RUN   TestAccCloudflareAccessApplicationWithEnableBindingCookie
--- PASS: TestAccCloudflareAccessApplicationWithEnableBindingCookie (3.79s)
=== RUN   TestAccCloudflareAccessApplicationWithCustomDenyFields
--- PASS: TestAccCloudflareAccessApplicationWithCustomDenyFields (3.48s)
=== RUN   TestAccCloudflareAccessApplicationWithADefinedIdps
--- PASS: TestAccCloudflareAccessApplicationWithADefinedIdps (5.43s)
=== RUN   TestAccCloudflareAccessApplicationWithZoneID
--- PASS: TestAccCloudflareAccessApplicationWithZoneID (4.63s)
=== RUN   TestAccCloudflareAccessApplicationWithMissingCORSMethods
--- PASS: TestAccCloudflareAccessApplicationWithMissingCORSMethods (0.08s)
=== RUN   TestAccCloudflareAccessApplicationWithMissingCORSOrigins
--- PASS: TestAccCloudflareAccessApplicationWithMissingCORSOrigins (0.09s)
=== RUN   TestAccCloudflareAccessApplicationWithInvalidSessionDuration
--- PASS: TestAccCloudflareAccessApplicationWithInvalidSessionDuration (0.04s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	33.986s
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]

[sboschman]

Why is this computed field removed? https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/cloudflare/resource_cloudflare_access_mutual_tls_certificate.go#L28 also uses computed=true with a choice between account_id and zone_id.

Since upgrading to 2.21.0 to 2.22.0 I am unable to render cloudflare_access_application resources. It used to work without account_id and zone_id on the resource, as the account_id is supplied to the provider. This now results in Error: error creating Access resource: zone_id or account_id required. Supplying either account_id or zone_id explicitly to the resource throws the same error. If you define both account_id and zone_id at the same time it throws the expected errors: Error: "account_id": conflicts with zone_id and Error: "zone_id": conflicts with account_id

State (notice the empty account_id):

          "resources": [
            {
              "type": "cloudflare_access_application",
              "provider_name": "registry.terraform.io/cloudflare/cloudflare",
              "schema_version": 0,
              "values": {
                "account_id": "",
                "zone_id": null

[jacobbednarz]

please open an issue following the issue template; this PR has already been merged.