Cloudflare LoadBalancer support for Pool Latitude and Longitude

[tpolich]

Added support for Latitude/Longitude for load balancer pools.

Removed duplicated float validation function replaced with standard version from validation package.

[jacobbednarz]

are you able to remove this from the PR? we generally bump dependencies outside of the functionality and then just merge the feature once it is ready. this does mean we're pending the release of cloudflare-go but that is generally 👌

[tpolich]

I don't think I can that hash is the first commit containing the Latitude and Longitude fields on cloudflare.LoadBalancerPool they don't exist in the last released version.

[jacobbednarz]

yep, that's expected. we'll have an error on the build here in GitHub but once we cut a new release of cloudflare-go, this will get the update and won't have to deal with conflicts as it will change underneath it. if we leave this here and in other PRs, all of them will have to resolve go.mod and go.sum conflicts upon update which are no fun for anyone.

when i pull the tests locally, i can shim in the latest master version too using go's replace in the go.mod file to roughly check it out.

[tpolich]

makes sense I've removed the mod changes from this PR

[jacobbednarz]

we'll also want to update https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/website/docs/r/load_balancer.html.markdown to add the new values and descriptions to the website documentation.

[tpolich]

we'll also want to update https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/website/docs/r/load_balancer.html.markdown to add the new values and descriptions to the website documentation.

I always forget about that. I've added latitude and longitude to the pool documentation.

[jacobbednarz]

lgtm, just waiting on cloudflare-go's release to get this merged

[jacobbednarz]

Rebased in latest master to get the latest cloudflare-go changes.

[jacobbednarz]

looks like we've got a type issue here with the float64 vs *float32

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareLoadBalancerPool" -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareLoadBalancerPool_Import
=== PAUSE TestAccCloudflareLoadBalancerPool_Import
=== RUN   TestAccCloudflareLoadBalancerPool_Basic
=== PAUSE TestAccCloudflareLoadBalancerPool_Basic
=== RUN   TestAccCloudflareLoadBalancerPool_FullySpecified
=== PAUSE TestAccCloudflareLoadBalancerPool_FullySpecified
=== RUN   TestAccCloudflareLoadBalancerPool_CreateAfterManualDestroy
=== PAUSE TestAccCloudflareLoadBalancerPool_CreateAfterManualDestroy
=== CONT  TestAccCloudflareLoadBalancerPool_Import
--- PASS: TestAccCloudflareLoadBalancerPool_Import (4.82s)
=== CONT  TestAccCloudflareLoadBalancerPool_CreateAfterManualDestroy
--- PASS: TestAccCloudflareLoadBalancerPool_CreateAfterManualDestroy (6.14s)
=== CONT  TestAccCloudflareLoadBalancerPool_FullySpecified
panic: interface conversion: interface {} is float64, not *float32

goroutine 1663 [running]:
github.com/cloudflare/terraform-provider-cloudflare/cloudflare.resourceCloudflareLoadBalancerPoolCreate(0xc0005a53b0, 0x2289a60, 0xc000201080, 0x2, 0x2d8d1c0)
	/Users/jacob/go/src/github.com/cloudflare/terraform-provider-cloudflare/cloudflare/resource_cloudflare_load_balancer_pool.go:169 +0x953
github.com/hashicorp/terraform-plugin-sdk/helper/schema.(*Resource).Apply(0xc00030d180, 0xc000d09900, 0xc001019420, 0x2289a60, 0xc000201080, 0x20b5801, 0xc0010942b8, 0xc0010157d0)
	/Users/jacob/.asdf/installs/golang/1.15.6/packages/pkg/mod/github.com/hashicorp/terraform-plugin-sdk@v1.17.2/helper/schema/resource.go:320 +0x375
github.com/hashicorp/terraform-plugin-sdk/helper/schema.(*Provider).Apply(0xc0006b6480, 0xc00107da38, 0xc000d09900, 0xc001019420, 0xc001017048, 0xc001007ab0, 0x20b87a0)
	/Users/jacob/.asdf/installs/golang/1.15.6/packages/pkg/mod/github.com/hashicorp/terraform-plugin-sdk@v1.17.2/helper/schema/provider.go:294 +0x99
github.com/hashicorp/terraform-plugin-sdk/internal/helper/plugin.(*GRPCProviderServer).ApplyResourceChange(0xc00018a378, 0x2518f60, 0xc001008e70, 0xc0005a4ee0, 0xc00018a378, 0xc001008e70, 0xc00011aba0)
	/Users/jacob/.asdf/installs/golang/1.15.6/packages/pkg/mod/github.com/hashicorp/terraform-plugin-sdk@v1.17.2/internal/helper/plugin/grpc_provider.go:895 +0x8ab
github.com/hashicorp/terraform-plugin-sdk/internal/tfplugin5._Provider_ApplyResourceChange_Handler(0x2238fc0, 0xc00018a378, 0x2518f60, 0xc001008e70, 0xc000afed80, 0x0, 0x2518f60, 0xc001008e70, 0xc001010400, 0x3c6)
	/Users/jacob/.asdf/installs/golang/1.15.6/packages/pkg/mod/github.com/hashicorp/terraform-plugin-sdk@v1.17.2/internal/tfplugin5/tfplugin5.pb.go:3305 +0x214
google.golang.org/grpc.(*Server).processUnaryRPC(0xc0002c0c40, 0x2527a60, 0xc000c2a180, 0xc00073a900, 0xc00090c7b0, 0x2d47980, 0x0, 0x0, 0x0)
	/Users/jacob/.asdf/installs/golang/1.15.6/packages/pkg/mod/google.golang.org/grpc@v1.32.0/server.go:1194 +0x522
google.golang.org/grpc.(*Server).handleStream(0xc0002c0c40, 0x2527a60, 0xc000c2a180, 0xc00073a900, 0x0)
	/Users/jacob/.asdf/installs/golang/1.15.6/packages/pkg/mod/google.golang.org/grpc@v1.32.0/server.go:1517 +0xd05
google.golang.org/grpc.(*Server).serveStreams.func1.2(0xc00089e050, 0xc0002c0c40, 0x2527a60, 0xc000c2a180, 0xc00073a900)
	/Users/jacob/.asdf/installs/golang/1.15.6/packages/pkg/mod/google.golang.org/grpc@v1.32.0/server.go:859 +0xa5
created by google.golang.org/grpc.(*Server).serveStreams.func1
	/Users/jacob/.asdf/installs/golang/1.15.6/packages/pkg/mod/google.golang.org/grpc@v1.32.0/server.go:857 +0x1fd
FAIL	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	11.639s
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]
FAIL
make: *** [testacc] Error 1

[jacobbednarz]

Ah, I remembered why. Terraform schema TypeFloat is float64, not float32. You'll need to convert it in your schema definition for this to work.

[jacobbednarz]

We're up and running now but it looks like the float is extremely precise 😛

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareLoadBalancerPool" -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareLoadBalancerPool_Import
=== PAUSE TestAccCloudflareLoadBalancerPool_Import
=== RUN   TestAccCloudflareLoadBalancerPool_Basic
=== PAUSE TestAccCloudflareLoadBalancerPool_Basic
=== RUN   TestAccCloudflareLoadBalancerPool_FullySpecified
=== PAUSE TestAccCloudflareLoadBalancerPool_FullySpecified
=== RUN   TestAccCloudflareLoadBalancerPool_CreateAfterManualDestroy
=== PAUSE TestAccCloudflareLoadBalancerPool_CreateAfterManualDestroy
=== CONT  TestAccCloudflareLoadBalancerPool_Import
--- PASS: TestAccCloudflareLoadBalancerPool_Import (3.54s)
=== CONT  TestAccCloudflareLoadBalancerPool_CreateAfterManualDestroy
--- PASS: TestAccCloudflareLoadBalancerPool_CreateAfterManualDestroy (6.32s)
=== CONT  TestAccCloudflareLoadBalancerPool_FullySpecified
    testing.go:705: Step 0 error: Check failed: Check 6/8 error: cloudflare_load_balancer_pool.ducrcjbrmx: Attribute 'latitude' expected "12.3", got "12.300000190734863"
--- FAIL: TestAccCloudflareLoadBalancerPool_FullySpecified (2.82s)
=== CONT  TestAccCloudflareLoadBalancerPool_Basic
--- PASS: TestAccCloudflareLoadBalancerPool_Basic (3.22s)
FAIL
FAIL	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	16.368s
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]
FAIL
make: *** [testacc] Error 1

Do we want to trim this to only store a single degree of accuracy instead of 15?

[jacobbednarz]

looking good here too!

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareLoadBalancerPool_" -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareLoadBalancerPool_Import
=== PAUSE TestAccCloudflareLoadBalancerPool_Import
=== RUN   TestAccCloudflareLoadBalancerPool_Basic
=== PAUSE TestAccCloudflareLoadBalancerPool_Basic
=== RUN   TestAccCloudflareLoadBalancerPool_FullySpecified
=== PAUSE TestAccCloudflareLoadBalancerPool_FullySpecified
=== RUN   TestAccCloudflareLoadBalancerPool_CreateAfterManualDestroy
=== PAUSE TestAccCloudflareLoadBalancerPool_CreateAfterManualDestroy
=== CONT  TestAccCloudflareLoadBalancerPool_Import
--- PASS: TestAccCloudflareLoadBalancerPool_Import (3.19s)
=== CONT  TestAccCloudflareLoadBalancerPool_CreateAfterManualDestroy
--- PASS: TestAccCloudflareLoadBalancerPool_CreateAfterManualDestroy (4.83s)
=== CONT  TestAccCloudflareLoadBalancerPool_FullySpecified
--- PASS: TestAccCloudflareLoadBalancerPool_FullySpecified (2.79s)
=== CONT  TestAccCloudflareLoadBalancerPool_Basic
--- PASS: TestAccCloudflareLoadBalancerPool_Basic (2.54s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	14.058s
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]