Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't concatenate domain during lookup if it is root domain #1129

Merged
merged 3 commits into from
Jul 16, 2021
Merged

fix: don't concatenate domain during lookup if it is root domain #1129

merged 3 commits into from
Jul 16, 2021

Conversation

MrLemur
Copy link

@MrLemur MrLemur commented Jul 12, 2021

This adds a check to see if domain being queried is the root domain value.

This is required when using allow_overwrite as it wil fail to overwrite when the name variable equals @, representing the root domain.

Closes #1128

@MrLemur MrLemur requested a review from jacobbednarz July 14, 2021 07:36
@jacobbednarz jacobbednarz merged commit 48e7299 into cloudflare:master Jul 16, 2021
@jacobbednarz
Copy link
Member

lgtm! thank you! 🍰

@MrLemur MrLemur deleted the fix/allow-overwrite-root-lookup branch July 16, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz Awaiting requested review from jacobbednarz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

resource/cloudflare_record: allow_overwrite fails to find root domain when @ supplied as name variable
2 participants
@MrLemur @jacobbednarz