Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page rule lacks support for Auto Minify and Polish #114

Closed
bradenex opened this issue Sep 6, 2018 · 3 comments
Closed

Page rule lacks support for Auto Minify and Polish #114

bradenex opened this issue Sep 6, 2018 · 3 comments

Comments

@bradenex
Copy link

bradenex commented Sep 6, 2018

Currently there is no support for Auto Minify in resource_cloudflare_page_rule.go and, in the same file, Polish settings only allow for on and off . When on is used, this error is returned:

cloudflare_page_rule.cloudflare_rule_www: Failed to create page rule: error from makeRequest: HTTP status 400: content "{\"success\":false,\"errors\":[{\"code\":1004,\"message\":\"Page Rule validation failed: See messages for details.\"}],\"messages\":[{\"code\":1,\"message\":\".settings[0].value: Polish can only be off, lossless or lossy\",\"type\":null}],\"result\":null}"

When using lossless or lossy, this error is returned:
Error: cloudflare_page_rule.cloudflare_rule_www: expected actions.0.polish to be one of [on off], got lossless

Both of these settings have support in resource_cloudflare_zone_settings_override.go but not in Page Rules.

@patryk
Copy link
Contributor

patryk commented Sep 18, 2018

Fixed by #116. Thanks for report Braden!

@patryk patryk closed this as completed Sep 18, 2018
@bradenex
Copy link
Author

Thanks! However, only half of this issue has been resolved. I'm still not seeing any support for Auto-minify.

@SteveGoldthorpe-Work
Copy link
Contributor

Yip I only fixed the Polish issue - the other is more complex and I wanted to get the Polish fix out of the way whilst I had the time.
Technically the Polish issue was a bug and the Auto Minify issue is an enhancement.
Probably easier to create a new issue for Auto Minify and keep to one thing per issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants