Revathy/add webhooks resource #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbednarz
reviewed
Aug 5, 2021
jacobbednarz
reviewed
Aug 5, 2021
| if err != nil { | ||
| return fmt.Errorf("error retrieving notification webhooks %s: %s", name, err) | ||
| } | ||
| id, err := uuid.Parse(notificationWebhooks.Result.ID) |
There was a problem hiding this comment.
jacobbednarz
reviewed
Aug 5, 2021
| if err != nil { | ||
| return fmt.Errorf("error setting notification webhooks %s: %s", name, err) | ||
| } | ||
| d.Set("id", id.String()) |
There was a problem hiding this comment.
the Create should be suffice for setting the resource ID as we shouldn't need to change it after the fact. this value is often used as an "anchor" for lookups and should remain consistent.
side note: setting the resource ID should use d.SetId() as it is a special attribute.
There was a problem hiding this comment.
removed this now and verified that the tests are passing.
jacobbednarz
reviewed
Aug 5, 2021
| "github.com/hashicorp/terraform-plugin-sdk/helper/resource" | ||
| ) | ||
|
|
||
| func TestAccCloudflareNotificationPolicyWebhooks(t *testing.T) { |
There was a problem hiding this comment.
acceptance tests are 🍏
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareNotificationPolicyWebhooks" -timeout 120m -parallel 1
? github.com/cloudflare/terraform-provider-cloudflare [no test files]
=== RUN TestAccCloudflareNotificationPolicyWebhooks
--- PASS: TestAccCloudflareNotificationPolicyWebhooks (9.56s)
PASS
ok github.com/cloudflare/terraform-provider-cloudflare/cloudflare 10.261s
? github.com/cloudflare/terraform-provider-cloudflare/version [no test files]
|
couple of questions but nothing major! such speed for your 2nd PR! |
revathyrams
force-pushed
the
revathy/add-webhooks-resource
branch
from
0a1e31b to
a3ac307
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.