Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GATE-1848: Adds support for gateway location API #1154

Conversation

Michael9127
Copy link
Contributor

@Michael9127 Michael9127 commented Aug 9, 2021

https://api.cloudflare.com/#teams-locations-properties

Relevant cloudflare-go commit: cloudflare/cloudflare-go@b24251b

Testing:

  • Added acceptance test
  • Manually tested CRUD and import functionality manually

@Michael9127
Copy link
Contributor Author

Michael9127 commented Aug 9, 2021

just realized theres a github action to release cloudflare-go. Gonna wait for cloudflare/cloudflare-go#693 to get in, get a release, and update this PR to an actual version instead of pinning to that single commit before merging

@Michael9127 Michael9127 force-pushed the mike/GATE-1848-gateway-terraform-support branch 2 times, most recently from edb6089 to 6aa3656 Compare August 9, 2021 18:19
@jacobbednarz
Copy link
Member

cool, let's wait for that PR to land and we can review this one.

@jacobbednarz
Copy link
Member

@Michael9127 looks like you've still got the go.mod and go.sum files in this PR. do you want to remove them and update to master as the release has been cut?

@jacobbednarz jacobbednarz force-pushed the mike/GATE-1848-gateway-terraform-support branch 2 times, most recently from 150852c to caf789b Compare August 26, 2021 23:49
@jacobbednarz jacobbednarz force-pushed the mike/GATE-1848-gateway-terraform-support branch from caf789b to 6a65612 Compare August 26, 2021 23:51
@jacobbednarz
Copy link
Member

integration looks good

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareTeamsLocation" -count 1 -timeout 120m -parallel 1
go: downloading github.com/cloudflare/cloudflare-go v0.21.0
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareTeamsLocationBasic
--- PASS: TestAccCloudflareTeamsLocationBasic (2.84s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	3.532s
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]

@jacobbednarz jacobbednarz merged commit 63fb5f4 into cloudflare:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants