Correctly set multi_script on Enterprise worker imports
#124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the import for `cloudflare_worker_route` resource. Prior to
this it relied on `d.Get("script_name")` which was never accessible so
it would always return an empty string (even when using
`getRouteFromResource`).
With this change, it now queries the Cloudflare API fetching all worker
routes and when the route ID matches one in the API response, it will
set the `isEnterpriseWorker` flag to `true` which will correctly set the
`multi_script` option. This includes the prerequisitie that the
organisation ID must also be set to enable it which maintains
compatibility with the existing behaviour.
Fixes #123
ghost
added
the
|
Thanks Jacob! |
|
Is it possible to release new version with this change? It prevents us from terraforming all workers :) |
|
It looks like this just missed the 1.7.0 release. There have been quite
a few changes since the last release
(hashicorp@v1.7.0...master) so I can't imagine a fresh release is too far away.
|
|
Alternatively, you could build the provider locally until a new release
has been cut. See
https://github.com/terraform-providers/terraform-provider-cloudflare#building-the-provider
for full details.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the import for
cloudflare_worker_routeresource. Prior tothis it relied on
d.Get("script_name")which was never accessible soit would always return an empty string (even when using
getRouteFromResource).With this change, it now queries the Cloudflare API fetching all worker
routes and when the route ID matches one in the API response, it will
set the
isEnterpriseWorkerflag totruewhich will correctly set themulti_scriptoption. This includes the prerequisitie that theorganisation ID must also be set to enable it which maintains
compatibility with the existing behaviour.
Fixes #123