Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/cloudflare_ruleset: don't attempt to update the phase for "custom" rulesets #1245

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

jacobbednarz
Copy link
Member

After creating the base Ruleset, we usually attempt to update it in place
however Rulesets with a "custom" kind don't need this so we can remove it.

Closes #1242

@jacobbednarz jacobbednarz force-pushed the account-level-custom-ruleset-fix branch 2 times, most recently from d594201 to 1e592b8 Compare October 12, 2021 03:07
…ustom" rulesets

After creating the base Ruleset, we usually attempt to update it in place
however Rulesets with a "custom" kind don't need this so we can remove it.

Closes #1242
@jacobbednarz jacobbednarz force-pushed the account-level-custom-ruleset-fix branch from 1e592b8 to 36a1e9f Compare October 12, 2021 03:08
@jacobbednarz jacobbednarz merged commit bd1e6ba into master Oct 14, 2021
@jacobbednarz jacobbednarz deleted the account-level-custom-ruleset-fix branch October 14, 2021 19:39
github-actions bot pushed a commit that referenced this pull request Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruleset for account with kind custom should not use entrypoint
1 participant