WDAPI-645 add a device posture integration #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing pending the cloudflare-go library update. |
patryk
force-pushed
the
aplunk/WDAPI-645
branch
from
100e2a2 to
28f6f7c
Compare
patryk
added
kind/enhancement
patryk
suggested changes
Dec 22, 2021
patryk
added
kind/new-resource
Thanks for the review, I will update documentation.
Regarding failing tests, to run these tests one would need an account with the third party service workspace one. Is there a good way to contribute a test which does not require access to a third party api? |
aplunk
force-pushed
the
aplunk/WDAPI-645
branch
2 times, most recently
from
5b71a30 to
884de6e
Compare
aplunk
force-pushed
the
aplunk/WDAPI-645
branch
from
884de6e to
4367580
Compare
patryk
approved these changes
Jan 5, 2022
patryk
removed
workflow/pending-contributor-response
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: cloudflare/cloudflare-go#749
This PR adds support for the device posture integration APIs.
Testing is difficult because the third party integrations require special account configuration. Please advise on the best way to integrate this into CI.