-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloudflare_fallback_domain support for default entries #1399
cloudflare_fallback_domain support for default entries #1399
Conversation
Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md. Example:
If you do not require a release note to be included, please add the |
…patibility with existing behavior
thanks for the PR! i've gone through and added comments inline but this PR does raise some provider design questions which i don't think we've quite ironed out in the current state. the two big things:
|
OK. I've updated this PR to simplify everything. It now will reset the default entries on delete, always. It also updates the documentation to explicitly show how to add entries to the default list. If you hear from the service teams on being able to support an API endpoint to reset defaults, we can change to that. I guess it'd be up to you on if you'd rather wait for that or do this now and then update once it's available. |
pending cloudflare/cloudflare-go#784 |
3074611
to
9a9842f
Compare
This should close #1385 and adds two new options (enabled by default) to support the default entries provided by teams initially and to support restoring those entries on resource deletion. This updates the behavior to align with the docs and the intended behavior most folks expect, while providing control to customize the behavior.