Validate TXT records #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TXT records must contain only printable ASCII - viz. character codes 32 through 127.
TXT records must contain only printable ASCII, which was previously going unchecked; resulting in an `apply`-time error from the CF API. This commit resolves cloudflare#9.
elithrar
approved these changes
Jul 6, 2017
|
LGTM (I work at Cloudflare) |
radeksimko
approved these changes
Sep 14, 2017
radeksimko
added
the
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an implementation of validation for TXT records, which must consist only of printable ASCII characters.
Resolves #9.