Make cloudflare_access_rule importable for all rule types
#141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are currently three different levels of firewall access rules: - `user`: Applied to a personal account - `zone`: Applied to an account but restricted to a single zone - `account`: Applied to all sites within an account Prior to this commit, importing was only available for the user type which made it unusable for organisations or users with multiple zones that they wanted to manage. As a result of this change, the import identifier has changed. It now requires: - `accessRuleType`: Either `account`, `zone` or `user` (`user is pretty much a noop`) - `accessRuleIdentifier`: The ID of the access rule type you intend to use (`zone.id` or `account.id`). - `identifierValue`: The access rule ID from the API. Included here is an update to the documentation for the provider website for the new identifier values and import usage. Fixes #118
ghost
added
the
|
Yes, I think wording is clear enough, we may fine tune it in the future, if problems arise (unlikely). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently three different levels of firewall access rules:
user: Applied to a personal accountzone: Applied to an account but restricted to a single zoneaccount: Applied to all sites within an accountPrior to this commit, importing was only available for the user type
which made it unusable for organisations or users with multiple zones
that they wanted to manage.
As a result of this change, the import identifier has changed. It now
requires:
accessRuleType: Eitheraccount,zoneoruser(user is pretty much a noop)accessRuleIdentifier: The ID of the access rule type you intend touse (
zone.idoraccount.id).identifierValue: The access rule ID from the API.I've attempted to make this wording explain the different pieces that
are needed however I'm open to suggestions if someone has something
better.
Included here is an update to the documentation for the provider
website for the new identifier values and import usage.
Fixes #118