Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support managed_challenge for custom_pages #1478

Merged
merged 3 commits into from
Apr 19, 2022

Conversation

Nmishin
Copy link
Contributor

@Nmishin Nmishin commented Feb 21, 2022

For #1458

@github-actions
Copy link
Contributor

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

.changelog/1478.txt Outdated Show resolved Hide resolved
@jacobbednarz
Copy link
Member

we'll need to get the public documentation updated before we land this one - https://api.cloudflare.com/#custom-pages-for-a-zone-properties

@jacobbednarz jacobbednarz added the workflow/pending-public-documentation Indicates an issue or PR requires changes to public documentation confirming suitability for use. label Feb 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2022

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@clafollett
Copy link

We are in need of this PR being approved. Any way we can get this pushed through. We have managed challenges in production but can't back fill our TF configs to match and now our deployments error out.

@jacobbednarz
Copy link
Member

i'm tracking the internal ticket for this and i'm hoping this will land in time for the next release.

@jacobbednarz jacobbednarz merged commit 604f903 into cloudflare:master Apr 19, 2022
@github-actions github-actions bot added this to the v3.13.0 milestone Apr 19, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v3.13.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/pending-public-documentation Indicates an issue or PR requires changes to public documentation confirming suitability for use.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants