Compare cloudflare_record name without the zone name
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When importing `cloudflare_record` resources the `name` attribute is trimmed[1] to exclude the `domain` value. This creates an issue if you import the resources but use the full the domain as the `name` attribute because the Terraform state file will never match what is stored and will result in continuious changes wanting to be applied. After a brief discussion on the issue[2], it was decided that instead of limiting to what can be passed into the `name` attribute, we should use a `DiffSuppressFunc` that will allow the partial labels and full FQDNs to work by trimming the zone name as a part of the comparison. This will be the least amount of friction and maintain full backwards compatibility. Fixes #148. [1]: https://github.com/terraform-providers/terraform-provider-cloudflare/blob/ef8e9abfdb12bfd200520771792089c2a7129af0/cloudflare/resource_cloudflare_record.go#L513 [2]: https://github.com/terraform-providers/terraform-provider-cloudflare/issues/148#issuecomment-438507279
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing
cloudflare_recordresources thenameattribute istrimmed to exclude the
domainvalue. This creates an issue if youimport the resources but use the full the domain as the
nameattributebecause the Terraform state file will never match what is stored and
will result in continuious changes wanting to be applied.
After a brief discussion on the issue, it was decided that instead of
limiting to what can be passed into the
nameattribute, we should usea
DiffSuppressFuncthat will allow the partial labels and full FQDNsto work by trimming the zone name as a part of the comparison. This will
be the least amount of friction and maintain full backwards
compatibility.
Fixes #148.