fix: detect zone dnssec as enabled when in pending status #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xabier Napal <xabier.napal@dvzr.io>
|
Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md. Example: If you do not require a release note to be included, please add the |
Signed-off-by: Xabier Napal <xabier.napal@dvzr.io>
|
This functionality has been released in v3.12.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1486
This PR does not fully fix that issue because it addresses two different errors and I think one of them is a bug either in the Cloudflare API or the Go client: #1486 (comment).
With this change, zones with DNSSEC in
pendingstate (when the DS record has not been added or detected yet) won't throw aDNSSEC is already enablederror. The code expected thestatevalue of the DNSSEC API request was only one ofactiveordisabled, but thependingstate also represents an enabled DNSSEC, only that is not fully configured yet.