Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Access bookmarks resource #1539

Merged
merged 2 commits into from
Apr 1, 2022

Conversation

Justin-Holmes
Copy link
Contributor

@Justin-Holmes Justin-Holmes commented Mar 30, 2022

Resolves #1358

@github-actions
Copy link
Contributor

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

@jacobbednarz
Copy link
Member

thanks @Justin-Holmes 👏 tests are now passing locally

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareAccessBookmark_" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareAccessBookmark_Basic
--- PASS: TestAccCloudflareAccessBookmark_Basic (29.20s)
=== RUN   TestAccCloudflareAccessBookmark_WithZoneID
--- PASS: TestAccCloudflareAccessBookmark_WithZoneID (15.72s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	45.433s
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/maintainer-only-file-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/tf-log-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]

@jacobbednarz jacobbednarz merged commit e985ba0 into cloudflare:master Apr 1, 2022
@Justin-Holmes Justin-Holmes deleted the jholmes/bookmarks branch April 1, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudflare_access_application doesn't recognize bookmark type
2 participants