Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/cloudflare_api_token: ignore ordering changes in permission_groups #1545

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

jacobbednarz
Copy link
Member

Closes #1105

@jacobbednarz
Copy link
Member Author

acceptance tests are passing for this and the internal test failure which required a schema has cleared (unsure if it was addressed in terraform core).

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccAPIToken_" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccAPIToken_Basic
--- PASS: TestAccAPIToken_Basic (12.71s)
=== RUN   TestAccAPIToken_AllowDeny
--- PASS: TestAccAPIToken_AllowDeny (14.94s)
=== RUN   TestAccAPIToken_DoesNotSetConditions
--- PASS: TestAccAPIToken_DoesNotSetConditions (10.66s)
=== RUN   TestAccAPIToken_SetIndividualCondition
--- PASS: TestAccAPIToken_SetIndividualCondition (10.74s)
=== RUN   TestAccAPIToken_SetAllCondition
--- PASS: TestAccAPIToken_SetAllCondition (9.85s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	59.467s
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/maintainer-only-file-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/tf-log-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]

@jacobbednarz jacobbednarz merged commit bf7a2d8 into master Apr 4, 2022
@jacobbednarz jacobbednarz deleted the ignore-token-order branch April 4, 2022 03:20
github-actions bot pushed a commit that referenced this pull request Apr 4, 2022
@jacobbednarz jacobbednarz added this to the v3.12.0 milestone Apr 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

This functionality has been released in v3.12.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudflare_api_token permission_groups
1 participant