-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding IP type support for cloudflare teams list #1550
Adding IP type support for cloudflare teams list #1550
Conversation
Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md. Example:
If you do not require a release note to be included, please add the |
82fac1c
to
9c33864
Compare
I'm afraid we cannot accept this until we have the public documentation updated to reflect it the value being expected for public consumption. Have you got a support ticket requesting the documentation be updated yet? |
No i havn't. Whats the best way to proceed? |
I can make a ticket for the team however, there are no guarantees when it will be actioned. If you need it, I'd recommend opening a customer support ticket that will end up in the hands of the right team. |
Thanks @jacobbednarz will do. Should we leave this PR opened until API docs will be updated? |
yep, that's fine. once we have the documentation we merge this in. |
the public docs will be released next week but have been merged, thanks for the contributions! |
This functionality has been released in v3.14.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
This PR adds IP type support to cloudflare teams list.
I checked the cloudflare-go repo and could not find any validation performed on a type of a list.
Even though API docs does not mention IP type:
By looking at the response from GET '/lists' i was able verify that IP is actually supported:
I also tried to test it locally using terraform.
So far so good.
Please let me know if there is anything i am missing.
As our team would like to have that juicy feature available via terraform