Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding IP type support for cloudflare teams list #1550

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

sanicheev
Copy link

@sanicheev sanicheev commented Apr 6, 2022

This PR adds IP type support to cloudflare teams list.

I checked the cloudflare-go repo and could not find any validation performed on a type of a list.

Even though API docs does not mention IP type:
Screenshot from 2022-04-06 12-54-00

By looking at the response from GET '/lists' i was able verify that IP is actually supported:
Screenshot from 2022-04-06 17-08-14

I also tried to test it locally using terraform.
So far so good.

Please let me know if there is anything i am missing.
As our team would like to have that juicy feature available via terraform

@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

@sanicheev sanicheev force-pushed the team_list_support_ip_type branch from 82fac1c to 9c33864 Compare April 6, 2022 07:17
@jacobbednarz
Copy link
Member

I'm afraid we cannot accept this until we have the public documentation updated to reflect it the value being expected for public consumption. Have you got a support ticket requesting the documentation be updated yet?

@jacobbednarz jacobbednarz added the workflow/pending-public-documentation Indicates an issue or PR requires changes to public documentation confirming suitability for use. label Apr 6, 2022
@sanicheev
Copy link
Author

sanicheev commented Apr 6, 2022

I'm afraid we cannot accept this until we have the public documentation updated to reflect it the value being expected for public consumption. Have you got a support ticket requesting the documentation be updated yet?

No i havn't. Whats the best way to proceed?
Is it possible for you to create an internal ticket in cloudflare system to make this process faster?

@jacobbednarz
Copy link
Member

I can make a ticket for the team however, there are no guarantees when it will be actioned. If you need it, I'd recommend opening a customer support ticket that will end up in the hands of the right team.

@sanicheev
Copy link
Author

sanicheev commented Apr 6, 2022

Thanks @jacobbednarz will do. Should we leave this PR opened until API docs will be updated?

@jacobbednarz
Copy link
Member

yep, that's fine. once we have the documentation we merge this in.

@jacobbednarz
Copy link
Member

the public docs will be released next week but have been merged, thanks for the contributions!

@jacobbednarz jacobbednarz merged commit 5e5c305 into cloudflare:master Apr 28, 2022
@github-actions github-actions bot added this to the v3.14.0 milestone Apr 28, 2022
@github-actions
Copy link

github-actions bot commented May 3, 2022

This functionality has been released in v3.14.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/pending-public-documentation Indicates an issue or PR requires changes to public documentation confirming suitability for use.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants