Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expiration to posture rule #1585

Merged
merged 4 commits into from
May 11, 2022
Merged

Conversation

suhrit-cf
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

@suhrit-cf
Copy link
Contributor Author

@jacobbednarz fixed those two file.

@jacobbednarz
Copy link
Member

looks like you are still missing the CHANGELOG entry that the automation mentioned above. can you please add that too?

@jacobbednarz
Copy link
Member

we don't edit the CHANGELOG directly; if you check out https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md, it has the steps you need for adding it and having it generate correctly.

@suhrit-cf
Copy link
Contributor Author

@jacobbednarz added changelog

@jacobbednarz jacobbednarz self-requested a review as a code owner May 10, 2022 22:19
@jacobbednarz
Copy link
Member

acceptance tests look good.

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareDevicePostureRule" -count 1 -parallel 1 -timeout 120m -parallel 1
go: downloading golang.org/x/oauth2 v0.0.0-20220411215720-9780585627b5
go: downloading github.com/hashicorp/terraform-plugin-sdk/v2 v2.16.0
go: downloading github.com/cloudflare/cloudflare-go v0.39.0
go: downloading golang.org/x/net v0.0.0-20220412020605-290c469a71a5
go: downloading github.com/hashicorp/hc-install v0.3.2
go: downloading golang.org/x/sys v0.0.0-20220422013727-9388b58f7150
go: downloading google.golang.org/genproto v0.0.0-20220407144326-9054f6ed7bac
go: downloading golang.org/x/crypto v0.0.0-20220411220226-7b82a4e95df4
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareDevicePostureRuleSerialNumber
--- PASS: TestAccCloudflareDevicePostureRuleSerialNumber (13.40s)
=== RUN   TestAccCloudflareDevicePostureRuleOsVersion
--- PASS: TestAccCloudflareDevicePostureRuleOsVersion (13.32s)
=== RUN   TestAccCloudflareDevicePostureRuleDomainJoined
--- PASS: TestAccCloudflareDevicePostureRuleDomainJoined (11.96s)
=== RUN   TestAccCloudflareDevicePostureRuleFirewall
--- PASS: TestAccCloudflareDevicePostureRuleFirewall (12.02s)
=== RUN   TestAccCloudflareDevicePostureRuleDiskEncryption
--- PASS: TestAccCloudflareDevicePostureRuleDiskEncryption (10.34s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	61.550s
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/maintainer-only-file-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/tf-log-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]

@jacobbednarz jacobbednarz merged commit 101a6b8 into cloudflare:master May 11, 2022
@github-actions github-actions bot added this to the v3.15.0 milestone May 11, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v3.15.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants