Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle panic on parse workers kv id #1635

Merged
merged 2 commits into from
May 20, 2022

Conversation

broswen
Copy link
Contributor

@broswen broswen commented May 20, 2022

Currently the provider panics when an invalid id is used to import a cloudflare_workers_kv resource.

For example e8b09ec03fe84a7db31416f050c1d75c_test instead of e8b09ec03fe84a7db31416f050c1d75c/test will attempt to access an index out of range.

This change will throw an error explaining the issue and the id that is causing the panic instead of the provider panicking.

@broswen broswen requested a review from jacobbednarz as a code owner May 20, 2022 02:29
@github-actions
Copy link
Contributor

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

@jacobbednarz jacobbednarz merged commit 740daac into cloudflare:master May 20, 2022
@github-actions github-actions bot added this to the v3.16.0 milestone May 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

This functionality has been released in v3.16.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants