-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noan/add pkce idps #1667
Noan/add pkce idps #1667
Conversation
Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md. Example:
If you do not require a release note to be included, please add the |
looks good, just pending the upstream changes. you'll need to rebase this against |
f29e0ff
to
36f787b
Compare
Thanks for the update, rebased the PR with master. |
looks like we have some CI failures here that will need some attention before we merge. |
internal/provider/resource_cloudflare_access_identity_provider.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacob Bednarz <jacob.bednarz@hey.com>
Committed your change, please let me know if any other issues arise. |
This functionality has been released in v3.17.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Proof Key for Code Exchange (PKCE) has been recently added to the API and UI. This PR increases terraform functionality to match the API/UI.
As there was no unit tests relevant to the IDPs that support PKCE (azure, fb, google, google apps, okta, oidc), none were added.
However, creation and modification of these relevant IPDs with and without PKCE was tested with this updated provider against production.
Depends on: cloudflare/cloudflare-go#919