Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noan/add pkce idps #1667

Merged
merged 10 commits into from
Jun 13, 2022
Merged

Noan/add pkce idps #1667

merged 10 commits into from
Jun 13, 2022

Conversation

Noanan
Copy link
Contributor

@Noanan Noanan commented Jun 2, 2022

Proof Key for Code Exchange (PKCE) has been recently added to the API and UI. This PR increases terraform functionality to match the API/UI.

As there was no unit tests relevant to the IDPs that support PKCE (azure, fb, google, google apps, okta, oidc), none were added.

However, creation and modification of these relevant IPDs with and without PKCE was tested with this updated provider against production.

Depends on: cloudflare/cloudflare-go#919

@Noanan Noanan requested a review from jacobbednarz as a code owner June 2, 2022 14:21
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

.changelog/1652.txt Outdated Show resolved Hide resolved
@jacobbednarz
Copy link
Member

jacobbednarz commented Jun 7, 2022

looks good, just pending the upstream changes.

you'll need to rebase this against master as the documentation has moved. the file you're editing is now at templates/resources/cloudflare_access_identity_provider. alternatively, you can follow in the footsteps of #1677 and swap this resource to be automatically generated resources :)

@Noanan Noanan force-pushed the noan/add_pkce_idps branch from f29e0ff to 36f787b Compare June 7, 2022 14:42
@Noanan
Copy link
Contributor Author

Noanan commented Jun 7, 2022

Thanks for the update, rebased the PR with master.

@jacobbednarz
Copy link
Member

looks like we have some CI failures here that will need some attention before we merge.

Co-authored-by: Jacob Bednarz <jacob.bednarz@hey.com>
@Noanan
Copy link
Contributor Author

Noanan commented Jun 9, 2022

Committed your change, please let me know if any other issues arise.

@jacobbednarz jacobbednarz merged commit ed36fcf into cloudflare:master Jun 13, 2022
@github-actions github-actions bot added this to the v3.17.0 milestone Jun 13, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v3.17.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants