Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log zoneID as d.Get(zone) might return nil #1777

Merged
merged 1 commit into from
Jul 16, 2022
Merged

Log zoneID as d.Get(zone) might return nil #1777

merged 1 commit into from
Jul 16, 2022

Conversation

schans
Copy link
Contributor

@schans schans commented Jul 15, 2022 •
edited
Loading

This should fix #1776 where the provider crashes when an error is encountered.

@schans schans requested a review from jacobbednarz as a code owner July 15, 2022 12:01
@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2022 •
edited
Loading

changelog detected ✅

@schans
Log zoneID as d.Get(zone) might return nil
f773b31 
Update changelog

Properly do changelog

Align changelog name with PR number
@jacobbednarz
Copy link
Member

how does this address the issue? the variable you are using here is identical to the value at the start of the method.

@jacobbednarz
Copy link
Member

also, given zone_id is a required attribute, I'm unsure how it is possible for the value to be nil.

@schans
Copy link
Contributor Author

schans commented Jul 16, 2022

also, given zone_id is a required attribute, I'm unsure how it is possible for the value to be nil.

Hi! Thanks for looking into this. I had the exact same question initially ;-) Note that the original line referenced zone and not zone_id. I think that was the culprit.

@jacobbednarz
Copy link
Member

ah! good catch. that makes more sense :)

@jacobbednarz jacobbednarz merged commit c305d28 into cloudflare:master Jul 16, 2022
@github-actions github-actions bot added this to the v3.20.0 milestone Jul 16, 2022
github-actions bot pushed a commit that referenced this pull request Jul 16, 2022
Update CHANGELOG.md for #1777
8ae0ac9
@github-actions
Copy link
Contributor

This functionality has been released in v3.20.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz Awaiting requested review from jacobbednarz jacobbednarz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.20.0
Development

Successfully merging this pull request may close these issues.

Crash while generating error message while updating zone lockdown
2 participants
@schans @jacobbednarz