Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update misc SSL attributes #1778

Merged
merged 6 commits into from
Jul 19, 2022
Merged

Conversation

nickysemenza
Copy link
Member

@nickysemenza nickysemenza commented Jul 15, 2022

* remove references to long-deprecated dedicated certs (replaced by `advanced`)
* update the list of allowed certificate authorities
* fix some of the custom hostname docs copy

* remove references to long-deprecated dedicated certs (replaced by `advanced`)
* update the list of allowed certificate authorities
* fix some of the custom hostname docs copy
@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2022

changelog detected ✅

@jacobbednarz
Copy link
Member

jacobbednarz commented Jul 18, 2022

i've swapped these two resources over to autogenerated documentation but in doing so, uncovered that we don't have all the fields documented. up to you if you'd like to go through and add these before we merge. i'm fine either way.

something else that is problematic here is that we're using a TypeMap for the ownership_verification and ownership_verification_http nested objects. using a TypeMap pretty much means we don't have control over the keys and as such, can't document them automatically (among other internal issues). we may want to introduce a breaking change for 4.x to add this to the schema as a TypeList instead.

@nickysemenza
Copy link
Member Author

Oh cool I was curious about the 2 different docs. I can file a followup to improve the documentation more, I just fixed this since it was noticeably wrong :)

@jacobbednarz jacobbednarz merged commit 25c04a1 into cloudflare:master Jul 19, 2022
@github-actions github-actions bot added this to the v3.20.0 milestone Jul 19, 2022
github-actions bot pushed a commit that referenced this pull request Jul 19, 2022
@github-actions
Copy link
Contributor

This functionality has been released in v3.20.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants