Page rule zone attribute change to trigger new resource
#183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudflare#180 raised an issue whereby using a `cloudflare_page_rule` resource with a single resource identifier but multiple variables to change the `zone` attribute would attempt to update the page rule in place instead of re-creating it (see the attached issue for full reproduction steps). This isn't good as the `target` attribute needs to contain references to the `zone` in order to be successfully updated. To fix this, the schema details for `zone` has been updated to force a new resource on change. On the surface this change is fine however I can see a couple of scenarios where a `DiffSuppressFunc` that checks the host against the stored state file host might be needed in order to not create and delete unnecessarily and instead only create a new resource if the hosts are different. Fixes cloudflare#180
ghost
added
the
Creates a new method `testAccPreCheckAltDomain` to fail hard in the event the required environment variables aren't defined that are needed in order to successfully run these tests.
|
Thanks! |
boekkooi-lengoo
pushed a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this pull request
Feb 28, 2022
* Add support for Virtual DNS user analytics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#180 raised an issue whereby using a
cloudflare_page_ruleresourcewith a single resource identifier but multiple variables to change the
zoneattribute would attempt to update the page rule in place insteadof re-creating it (see the attached issue for full reproduction
steps). This isn't good as the
targetattribute needs to containreferences to the
zonein order to be successfully updated.To fix this, the schema details for
zonehas been updated to force anew resource on change. On the surface this change is fine however I can
see a couple of scenarios where a
DiffSuppressFuncthat checks thehost against the stored state file host might be needed in order to not
create and delete unnecessarily and instead only create a new resource
if the hosts are different.
Fixes #180