-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add os_distro_name and os_distro_revision #1842
Conversation
changelog detected ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'll need to check out https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/registry-documentation.md on how to have this documentation updated as docs
is the automatically generated version of these files.
I see, my bad. Thanks! |
b74219f
to
bbc554c
Compare
version = 1.0.0 | ||
operator = < | ||
os_distro_name = ubuntu | ||
os_distro_revision = 1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these fields aren't present in the schema or public API docs; so we won't be able to add them at this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're referencing non-existing API fields and schema values so this is unable to be merged. i'd suggest first getting the fields documentated then added to cloudflare-go before attempting to add them here.
these fields are now present in the Go library so you can add them to the schema, CRUD operations and the docs. |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
i've pushed a few fixes here but the test suite is still failing with a service error. do you mind looking into this and getting the tests in the right shape?
|
depends on cloudflare/cloudflare-go#1087 |
with the upstream PR shimmed in, tests are passing
|
72fad90
to
924f1e8
Compare
This functionality has been released in v3.25.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
update os_version device posture terraform docs for new linux fields