Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/cloudflare_access_service_token: allow in place refreshing #1872

Merged
merged 4 commits into from
Sep 1, 2022

Conversation

jacobbednarz
Copy link
Member

@jacobbednarz jacobbednarz commented Aug 31, 2022

Access Service Tokens are now refreshable and can be expiry extended in
place instead of recreation.

Closes #1866

Access Service Tokens are now refreshable and can be expiry extended in
place instead of recreation.
@github-actions
Copy link
Contributor

changelog detected ✅

@gitguardian
Copy link

gitguardian bot commented Sep 1, 2022

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
4318592 Generic High Entropy Secret 3c07bfb examples/resources/cloudflare_pages_project/resource.tf View secret
4318592 Generic High Entropy Secret 3c07bfb internal/provider/resource_cloudflare_pages_project_test.go View secret
4318592 Generic High Entropy Secret 3c07bfb internal/provider/resource_cloudflare_pages_project_test.go View secret
4318592 Generic High Entropy Secret e2f675a examples/resources/cloudflare_pages_project/resource.tf View secret
4318592 Generic High Entropy Secret e2f675a internal/provider/resource_cloudflare_pages_project_test.go View secret
4318592 Generic High Entropy Secret e2f675a internal/provider/resource_cloudflare_pages_project_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@jacobbednarz jacobbednarz merged commit 4137c25 into master Sep 1, 2022
@jacobbednarz jacobbednarz deleted the refresh-not-replace-tokens branch September 1, 2022 01:47
@github-actions github-actions bot added this to the v3.23.0 milestone Sep 1, 2022
github-actions bot pushed a commit that referenced this pull request Sep 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

This functionality has been released in v3.23.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudflare_access_service_token option to refresh only, not recreate
1 participant