Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WDAPI-1041 add device settings policy APIs #1926

Merged
merged 9 commits into from
Nov 18, 2022
Merged

WDAPI-1041 add device settings policy APIs #1926

merged 9 commits into from
Nov 18, 2022

Conversation

TylerStanish
Copy link
Contributor

@TylerStanish TylerStanish commented Sep 23, 2022 •
edited
Loading

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2022 •
edited
Loading

changelog detected ✅

@jacobbednarz jacobbednarz added the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Sep 27, 2022
@TylerStanish TylerStanish force-pushed the tstanish/WDAPI-1041 branch 2 times, most recently from 4b10311 to 1d46b40 Compare November 10, 2022 23:30
jacobbednarz
jacobbednarz requested changes Nov 13, 2022
View reviewed changes
Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

along with the inline comments, we'll also need to update the documentation.

internal/provider/schema_cloudflare_device_settings_policy.go Outdated Show resolved Hide resolved
internal/provider/resource_cloudflare_device_settings_policy.go Outdated Show resolved Hide resolved
internal/provider/resource_cloudflare_device_settings_policy.go Outdated Show resolved Hide resolved
internal/provider/resource_cloudflare_device_settings_policy_test.go Show resolved Hide resolved
internal/provider/resource_cloudflare_fallback_domain.go Outdated Show resolved Hide resolved
internal/provider/resource_cloudflare_fallback_domain.go Outdated Show resolved Hide resolved
internal/provider/resource_cloudflare_split_tunnel.go Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz removed the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Nov 15, 2022
@TylerStanish
Copy link
Contributor Author

Fixed semgrep issues

@jacobbednarz
Copy link
Member

acceptance tests all look good

TF_ACC=1 go test $(go list ./...) -v -run "^(TestAccCloudflareDeviceSettingsPolicy_|TestAccCloudflareFallbackDomain_|TestAccCloudflareSplitTunnel_)" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareDeviceSettingsPolicy_Create
--- PASS: TestAccCloudflareDeviceSettingsPolicy_Create (33.83s)
=== RUN   TestAccCloudflareFallbackDomain_Basic
--- PASS: TestAccCloudflareFallbackDomain_Basic (14.25s)
=== RUN   TestAccCloudflareFallbackDomain_DefaultPolicy
--- PASS: TestAccCloudflareFallbackDomain_DefaultPolicy (26.51s)
=== RUN   TestAccCloudflareFallbackDomain_WithAttachedPolicy
--- PASS: TestAccCloudflareFallbackDomain_WithAttachedPolicy (17.22s)
=== RUN   TestAccCloudflareSplitTunnel_Include
--- PASS: TestAccCloudflareSplitTunnel_Include (24.98s)
=== RUN   TestAccCloudflareSplitTunnel_ConflictingTunnelProperties
--- PASS: TestAccCloudflareSplitTunnel_ConflictingTunnelProperties (4.25s)
=== RUN   TestAccCloudflareSplitTunnel_Exclude
--- PASS: TestAccCloudflareSplitTunnel_Exclude (13.50s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/provider	135.086s

@jacobbednarz jacobbednarz merged commit f14a065 into cloudflare:master Nov 18, 2022
@github-actions github-actions bot added this to the v3.29.0 milestone Nov 18, 2022
@jacobbednarz
Copy link
Member

thanks for persisting with this one @TylerStanish, we got there in the end 👏

github-actions bot pushed a commit that referenced this pull request Nov 18, 2022
Update CHANGELOG.md for #1926
ceebb5a
@github-actions
Copy link
Contributor

This functionality has been released in v3.29.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz jacobbednarz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.29.0
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerStanish @jacobbednarz