Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add waiting room rules resource #1957

Merged
merged 7 commits into from
Oct 28, 2022
Merged

add waiting room rules resource #1957

merged 7 commits into from
Oct 28, 2022

Conversation

broswen
Copy link
Contributor

@broswen broswen commented Oct 10, 2022

This will need to wait until cloudflare-go has been released to include cloudflare/cloudflare-go#1102

We might also need to update some of the schema property descriptions to point to the Waiting Room specific docs. TBD

@broswen broswen requested a review from jacobbednarz as a code owner October 10, 2022 22:54
@broswen broswen force-pushed the add-waiting-room-rules branch from 8e54ff8 to 2171d77 Compare October 10, 2022 22:55
@github-actions
Copy link
Contributor

changelog detected ✅

@broswen broswen force-pushed the add-waiting-room-rules branch from 2171d77 to 7d29694 Compare October 11, 2022 15:22
@jacobbednarz jacobbednarz added the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Oct 14, 2022
@broswen broswen force-pushed the add-waiting-room-rules branch from 7d29694 to 4f64304 Compare October 18, 2022 19:12
@broswen broswen force-pushed the add-waiting-room-rules branch 2 times, most recently from a6cb4e3 to 6f9d8d8 Compare October 26, 2022 14:24
@broswen broswen force-pushed the add-waiting-room-rules branch from 6f9d8d8 to df72e40 Compare October 26, 2022 14:41
@broswen
Copy link
Contributor Author

broswen commented Oct 26, 2022

@jacobbednarz This should be good to go but it looks like some unit tests are failing for a different product.

@jacobbednarz jacobbednarz mentioned this pull request Oct 28, 2022
Merged
@jacobbednarz
Copy link
Member

looking good @broswen 💯

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareWaitingRoomRules" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareWaitingRoomRules_Create
=== PAUSE TestAccCloudflareWaitingRoomRules_Create
=== CONT  TestAccCloudflareWaitingRoomRules_Create
--- PASS: TestAccCloudflareWaitingRoomRules_Create (13.60s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/provider	14.083s

@jacobbednarz jacobbednarz merged commit 899b416 into cloudflare:master Oct 28, 2022
@github-actions github-actions bot added this to the v3.27.0 milestone Oct 28, 2022
github-actions bot pushed a commit that referenced this pull request Oct 28, 2022
Update CHANGELOG.md for #1957
eb0aef2
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

This functionality has been released in v3.27.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz Awaiting requested review from jacobbednarz jacobbednarz is a code owner

Assignees
No one assigned
Labels
workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library.
Projects
None yet
Milestone
v3.27.0
Development

Successfully merging this pull request may close these issues.
2 participants
@broswen @jacobbednarz