Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Total TLS Resource #1979

Merged
merged 6 commits into from
Oct 28, 2022
Merged

Create Total TLS Resource #1979

merged 6 commits into from
Oct 28, 2022

Conversation

Cyb3r-Jak3
Copy link
Contributor

Creates a new resource to manage the Total TLS setting.
Resolves #1967

@github-actions
Copy link
Contributor

changelog detected ✅

@Cyb3r-Jak3
Copy link
Contributor Author

This does work when replacing cloudflare-go with latest master

root@374a6841e75f:/workspaces/terraform-provider-cloudflare# TESTARGS='-run "^TestAccCloudflareTotalTLS" -count 1 -parallel 1' make testacc
TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareTotalTLS" -count 1 -parallel 1 -timeout 120m -parallel 1
?       github.com/cloudflare/terraform-provider-cloudflare     [no test files]
=== RUN   TestAccCloudflareTotalTLS
--- PASS: TestAccCloudflareTotalTLS (2.84s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/provider   2.856s

@jacobbednarz jacobbednarz added the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Oct 19, 2022
@jacobbednarz
Copy link
Member

acceptance tests looking good

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareTotalTLS" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareTotalTLS
--- PASS: TestAccCloudflareTotalTLS (10.33s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/provider	10.920s

@jacobbednarz jacobbednarz merged commit 94fceb6 into cloudflare:master Oct 28, 2022
@github-actions github-actions bot added this to the v3.27.0 milestone Oct 28, 2022
github-actions bot pushed a commit that referenced this pull request Oct 28, 2022
Update CHANGELOG.md for #1979
72ed249
@jacobbednarz
Copy link
Member

appreciate the effort here @Cyb3r-Jak3 🏆

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

This functionality has been released in v3.27.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@jacobbednarz jacobbednarz mentioned this pull request Dec 21, 2022
Merged
@Cyb3r-Jak3 Cyb3r-Jak3 deleted the totaltls branch April 15, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz jacobbednarz left review comments

Assignees
No one assigned
Labels
workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library.
Projects
None yet
Milestone
v3.27.0
Development

Successfully merging this pull request may close these issues.

Total TLS support
2 participants
@Cyb3r-Jak3 @jacobbednarz