Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where diffs are always shown in TF plans for Access policies #1983

Merged
merged 3 commits into from
Oct 19, 2022

Conversation

Justin-Holmes
Copy link
Contributor

This fixes a bug where Terraform plans were always showing a diff for Access policies despite no changes being made.

Closes #1215

@Justin-Holmes Justin-Holmes force-pushed the jholmes/fix-policy-diff branch from 6ac0175 to 9ad2c04 Compare October 19, 2022 21:12
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2022

changelog detected ✅

@jacobbednarz jacobbednarz force-pushed the jholmes/fix-policy-diff branch from d208876 to 492e873 Compare October 19, 2022 22:35
@jacobbednarz jacobbednarz force-pushed the jholmes/fix-policy-diff branch from 492e873 to 1895c05 Compare October 19, 2022 22:36
@jacobbednarz
Copy link
Member

added some more test coverage and we're still passing here

=== RUN   TestAccCloudflareAccessGroupConfig_BasicZone
--- PASS: TestAccCloudflareAccessGroupConfig_BasicZone (15.91s)
=== RUN   TestAccCloudflareAccessGroupConfig_BasicAccount
--- PASS: TestAccCloudflareAccessGroupConfig_BasicAccount (15.61s)
=== RUN   TestAccCloudflareAccessGroup_Exclude
--- PASS: TestAccCloudflareAccessGroup_Exclude (9.98s)
=== RUN   TestAccCloudflareAccessGroup_Require
--- PASS: TestAccCloudflareAccessGroup_Require (10.57s)
=== RUN   TestAccCloudflareAccessGroup_FullConfig
--- PASS: TestAccCloudflareAccessGroup_FullConfig (11.27s)
=== RUN   TestAccCloudflareAccessGroupWithIDP
--- PASS: TestAccCloudflareAccessGroupWithIDP (11.53s)
=== RUN   TestAccCloudflareAccessGroup_Updated
--- PASS: TestAccCloudflareAccessGroup_Updated (17.40s)
=== RUN   TestAccCloudflareAccessGroup_CreateAfterManualDestroy
--- PASS: TestAccCloudflareAccessGroup_CreateAfterManualDestroy (16.48s)
PASS
ok      github.com/cloudflare/terraform-provider-cloudflare/internal/provider   109.294s

@jacobbednarz jacobbednarz merged commit 3429444 into cloudflare:master Oct 19, 2022
@github-actions github-actions bot added this to the v3.27.0 milestone Oct 19, 2022
@jacobbednarz
Copy link
Member

cheers @Justin-Holmes 🏆

github-actions bot pushed a commit that referenced this pull request Oct 19, 2022
@Justin-Holmes Justin-Holmes deleted the jholmes/fix-policy-diff branch October 20, 2022 14:55
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

This functionality has been released in v3.27.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudflare_access_policy always detects changes when both group and email are included
2 participants