Add support for app_launcher, dash_sso and warp types on access applications #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
|
thanks! along with the changelog, we'll also need to run |
Comment on lines
49
to
50
| ValidateFunc: validation.StringInSlice([]string{"app_launcher", "bookmark", "dash_sso", "saas", "self_hosted", "ssh", "vnc", "warp"}, false), | ||
| Description: fmt.Sprintf("The application type. %s", renderAvailableDocumentationValuesStringSlice([]string{"app_launcher", "bookmark", "dash_sso", "saas", "self_hosted", "ssh", "vnc", "warp"})), |
There was a problem hiding this comment.
missing BISO here too - https://api.cloudflare.com/#access-applications-add-the-clientless-web-isolation-application
Suggested change
| ValidateFunc: validation.StringInSlice([]string{"app_launcher", "bookmark", "dash_sso", "saas", "self_hosted", "ssh", "vnc", "warp"}, false), | |
| Description: fmt.Sprintf("The application type. %s", renderAvailableDocumentationValuesStringSlice([]string{"app_launcher", "bookmark", "dash_sso", "saas", "self_hosted", "ssh", "vnc", "warp"})), | |
| ValidateFunc: validation.StringInSlice([]string{"app_launcher", "biso", "bookmark", "dash_sso", "saas", "self_hosted", "ssh", "vnc", "warp"}, false), | |
| Description: fmt.Sprintf("The application type. %s", renderAvailableDocumentationValuesStringSlice([]string{"app_launcher", "biso", "bookmark", "dash_sso", "saas", "self_hosted", "ssh", "vnc", "warp"})), |
…n access applications
ruimarinho
force-pushed
the
support/access-application-type
branch
from
e045a16 to
5a37960
Compare
|
Updated @jacobbednarz. |
|
awesome, thanks! |
|
This functionality has been released in v3.27.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current schema is missing a few types which can be imported by the provider but later on invalidated. This PR adds the following missing types:
app_launcherbisodash_ssowarp