Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where only last SAML rule group was applied in Access policy #2033

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

Justin-Holmes
Copy link
Contributor

Fixes a bug where SAML rule groups were overwritten so only the last rule was getting applied.

Closes #2018

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2022

changelog detected ✅

@jacobbednarz
Copy link
Member

acceptance tests look good, thanks!

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareAccessGroupConfig_" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareAccessGroupConfig_BasicZone
--- PASS: TestAccCloudflareAccessGroupConfig_BasicZone (19.02s)
=== RUN   TestAccCloudflareAccessGroupConfig_BasicAccount
--- PASS: TestAccCloudflareAccessGroupConfig_BasicAccount (19.01s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/provider	38.698s

@jacobbednarz jacobbednarz merged commit 4f655b5 into cloudflare:master Nov 17, 2022
@github-actions github-actions bot added this to the v3.29.0 milestone Nov 17, 2022
github-actions bot pushed a commit that referenced this pull request Nov 17, 2022
@Justin-Holmes Justin-Holmes deleted the jholmes/fix-saml-groups branch November 18, 2022 15:25
@github-actions
Copy link
Contributor

This functionality has been released in v3.29.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudflare_access_policy: When using multiple saml blocks in an include block, only the last one is saved
2 participants