Pass RateLimitCorrelate to flattenRateLimitCorrelate
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During an import of `cloudflare_rate_limit` resources, the NAT
correlation value isn't getting set however subsequent runs are.
Looking into this issue, I can see that the `d.Set("correlate")` aren't
calling the `flattenRateLimitCorrelate` with the required argument of a
`RateLimitCorrelate` type. I cannot see how this ever worked (even on
subsequent runs) but passing in the argument has addressed the issue
with importing.
Fixes #199
ghost
added
the
|
@patryk You've got more Golang chops than I do. Would you mind making sure I haven't missed something silly here or covering up an underlying bug? |
|
@jacobbednarz I've done it for this PR (and your other one), but will you please make sure that all user-facing PRs are mentioned in the Changelog after merging? 🙏 Thanks. 😉 |
|
Thanks! I wasn't sure if the automated releases stuff took care of that or
not 🙏🏻
…On Mon, 25 Feb 2019 at 18:54, Radek Simko ***@***.***> wrote:
@jacobbednarz <https://github.com/jacobbednarz> I've done it for this PR
(and your other one), but will you please make sure that all user-facing
PRs are mentioned in the Changelog
<https://github.com/terraform-providers/terraform-provider-cloudflare/blob/master/CHANGELOG.md>
after merging? 🙏
Thanks. 😉
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/terraform-providers/terraform-provider-cloudflare/pull/204#issuecomment-466906553>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARSYtFZGudNsJBI9UStd1cjEHv9jxBgks5vQ5aogaJpZM4adSH->
.
|
|
It is somewhere on our roadmap to look into (semi-)automating this problem for all providers, but we're not there yet, unfortunately. |
boekkooi-lengoo
pushed a commit
to boekkooi-lengoo/terraform-provider-cloudflare
that referenced
this pull request
Feb 28, 2022
updated LoadBalancer for SteeringPolicy support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During an import of
cloudflare_rate_limitresources, the NATcorrelation value isn't getting set however subsequent runs are.
Looking into this issue, I can see that the
d.Set("correlate")isn'tcalling the
flattenRateLimitCorrelatewith the required argument of aRateLimitCorrelatetype. I cannot see how this ever worked (even onsubsequent runs) but passing in the argument has addressed the issue
with importing.
Fixes #199