Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user_seat_expiration_inactive_time to Access organization #2115

Merged
merged 8 commits into from
Jan 17, 2023
Merged

Add user_seat_expiration_inactive_time to Access organization #2115

merged 8 commits into from
Jan 17, 2023

Conversation

Justin-Holmes
Copy link

Adds the user_seat_expiration_inactive_time field to an Access organization. I'll convert to a PR with docs and changelog entry once cloudflare-go version is updated with this change: cloudflare/cloudflare-go#1159.

@github-actions
Copy link

github-actions bot commented Dec 30, 2022 •
edited
Loading

changelog detected ✅

@jacobbednarz
Copy link
Member

with cloudflare-go@master shimmed in, acceptance tests are passing

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareAccessOrganization" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareAccessOrganization
--- PASS: TestAccCloudflareAccessOrganization (2.97s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/provider	3.420s

@jacobbednarz jacobbednarz added the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Jan 10, 2023
@Justin-Holmes Justin-Holmes marked this pull request as ready for review January 10, 2023 15:17
@Justin-Holmes
Copy link
Author

Thank you @jacobbednarz 🙏

@jacobbednarz jacobbednarz added service/access Categorizes issue or PR as related to the Access service. and removed workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. labels Jan 17, 2023
@jacobbednarz jacobbednarz merged commit 3ff8adb into cloudflare:master Jan 17, 2023
@github-actions github-actions bot added this to the v3.33.0 milestone Jan 17, 2023
github-actions bot pushed a commit that referenced this pull request Jan 17, 2023
Update CHANGELOG.md for #2115
f69193c
@Justin-Holmes Justin-Holmes deleted the jholmes/user-seat-expiration branch January 18, 2023 17:36
@github-actions
Copy link

This functionality has been released in v3.33.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz Awaiting requested review from jacobbednarz

Assignees
No one assigned
Labels
service/access Categorizes issue or PR as related to the Access service.
Projects
None yet
Milestone
v3.33.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Justin-Holmes @jacobbednarz