Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for mailto blockpage fields #2146

Merged
merged 3 commits into from
Jan 14, 2023
Merged

Adds support for mailto blockpage fields #2146

merged 3 commits into from
Jan 14, 2023

Conversation

Michael9127
Copy link
Contributor

No description provided.

@Michael9127 Michael9127 force-pushed the mike/update-gateway-blockpage-settings branch 2 times, most recently from 84b4656 to 9a260f4 Compare January 12, 2023 20:15
jacobbednarz
jacobbednarz reviewed Jan 12, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2023 •
edited
Loading

changelog detected ✅

@github-actions
Copy link
Contributor

This pull request contains a CHANGELOG.md file which should only be modified by maintainers.

If you are looking to include a CHANGELOG entry, you should use the process documented at https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/changelog-process.md instead.

In order for this pull request to be merged, you need remove the modifications to CHANGELOG.md.

@Michael9127 Michael9127 force-pushed the mike/update-gateway-blockpage-settings branch from 9a260f4 to 0d4345f Compare January 13, 2023 19:01
@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareTeamsAccountConfigurationBasic" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareTeamsAccountConfigurationBasic
--- PASS: TestAccCloudflareTeamsAccountConfigurationBasic (21.08s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/provider	21.498s

jacobbednarz
jacobbednarz reviewed Jan 14, 2023
View reviewed changes
.changelog/2146.txt Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit 3410642 into cloudflare:master Jan 14, 2023
@jacobbednarz
Copy link
Member

solid effort here, thanks @Michael9127

@github-actions github-actions bot added this to the v3.33.0 milestone Jan 14, 2023
github-actions bot pushed a commit that referenced this pull request Jan 14, 2023
Update CHANGELOG.md for #2146
20222d1
@jacobbednarz jacobbednarz mentioned this pull request Jan 14, 2023
Merged
@github-actions
Copy link
Contributor

This functionality has been released in v3.33.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@jacobbednarz jacobbednarz mentioned this pull request Feb 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz jacobbednarz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.33.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Michael9127 @jacobbednarz