Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where azure group rules would override each other #2270

Merged
merged 2 commits into from
Mar 5, 2023
Merged

Fix issue where azure group rules would override each other #2270

merged 2 commits into from
Mar 5, 2023

Conversation

Justin-Holmes
Copy link

Fixes an issue where Azure group rules with different identity provider ids would clobber each other.

@Justin-Holmes Justin-Holmes force-pushed the jholmes/fix-azure-groups branch from fec01d9 to 7cbed7c Compare March 3, 2023 00:06
jacobbednarz
jacobbednarz reviewed Mar 5, 2023
View reviewed changes
.changelog/2270.txt Outdated Show resolved Hide resolved
@jacobbednarz
Copy link
Member

acceptance tests are all good

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareAccessGroupConfig" -timeout 120m -parallel 1
=== RUN   TestAccCloudflareAccessGroupConfig_BasicZone
--- PASS: TestAccCloudflareAccessGroupConfig_BasicZone (22.23s)
=== RUN   TestAccCloudflareAccessGroupConfig_BasicAccount
--- PASS: TestAccCloudflareAccessGroupConfig_BasicAccount (22.12s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	45.326s

@jacobbednarz jacobbednarz merged commit b8a60cb into cloudflare:master Mar 5, 2023
@github-actions github-actions bot added this to the v4.1.0 milestone Mar 5, 2023
github-actions bot pushed a commit that referenced this pull request Mar 5, 2023
Update CHANGELOG.md for #2270
7c1ee94
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

changelog detected ✅

@Justin-Holmes Justin-Holmes deleted the jholmes/fix-azure-groups branch March 6, 2023 15:11
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

This functionality has been released in v4.1.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz jacobbednarz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Justin-Holmes @jacobbednarz