Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sentinelone type in the cloudflare_device_posture_rule schema #2278

Closed
aborrello opened this issue Mar 9, 2023 · 2 comments · Fixed by #2279
Closed

Support sentinelone type in the cloudflare_device_posture_rule schema #2278

aborrello opened this issue Mar 9, 2023 · 2 comments · Fixed by #2279
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. service/access Categorizes issue or PR as related to the Access service.
Milestone

Comments

@aborrello
Copy link

Current Terraform and Cloudflare provider version

Terraform version: 1.2.3
Cloudflare provider version: 3.30.0

Description

One undocumented component of the device posture API is the "support" for SentinelOne. This is currently implemented as the sentinelone type, which I believe itself is an alias for the application type. This request is to add sentinelone to the cloudflare_device_posture_rule schema validator.

A key difference is that existing checks created through the user interface already have the sentinelone type associated with them, making it difficult to import these rules into Terraform definitions. Additionally, the WARP Client UI displays SentinelOne checks and application checks differently, however, I suspect this is purely aesthetic.

Use cases

If a team has an existing WARP client posture rule for SentinelOne, it is challenging to import the check without creating a new rule entirely (as changing the type field will cause the resource to be destroyed and recreated). The ideal end state would be to allow Terraform definitions of the sentinelone type, bringing the provider in parity with the UI for this specific rule.

Potential Terraform configuration

resource "cloudflare_device_posture_rule" "edr" {
  account_id  = "123456789"
  name        = "My name"
  description = "My description"

  type     = "sentinelone"
  schedule = "5m"

  match {
    platform = "linux"
  }

  input {
    running    = true
    path       = "/path/to/sentineld"
    thumbprint = "xxx"
  }
}

References

No response

@aborrello aborrello added kind/enhancement Categorizes issue or PR as related to improving an existing feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 9, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@aborrello aborrello changed the title Support the sentinelone type in cloudflare_device_posture_rule resource Support sentinelone type in the cloudflare_device_posture_rule schema Mar 9, 2023
@jacobbednarz jacobbednarz added service/access Categorizes issue or PR as related to the Access service. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 9, 2023
@jacobbednarz jacobbednarz added this to the v4.5.0 milestone May 1, 2023
@github-actions
Copy link

github-actions bot commented May 3, 2023

This functionality has been released in v4.5.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement Categorizes issue or PR as related to improving an existing feature. service/access Categorizes issue or PR as related to the Access service.
Projects
None yet
2 participants