Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datasource cloudflare_list and cloudflare_lists #2296

Merged
merged 16 commits into from
Mar 20, 2023

Conversation

rwhelan
Copy link

@rwhelan rwhelan commented Mar 16, 2023

New data sources for getting list information.

  • cloudflare_lists: Returns all lists.
  • cloudflare_list: Takes the single attribute name and returns only the list with the matching name.

@rwhelan rwhelan requested a review from jacobbednarz as a code owner March 16, 2023 23:18
@github-actions
Copy link

changelog detected ✅

Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are looking good

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^(TestAccCloudflareListDataSource|TestAccCloudflareListsDataSource)" -timeout 120m -parallel 1
=== RUN   TestAccCloudflareListDataSource
--- PASS: TestAccCloudflareListDataSource (24.47s)
=== RUN   TestAccCloudflareListsDataSource
--- PASS: TestAccCloudflareListsDataSource (11.54s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	36.503s

we just need to tidy up a couple of these smaller things and we're good to go!

.changelog/2296.txt Outdated Show resolved Hide resolved
.changelog/2296.txt Outdated Show resolved Hide resolved
docs/data-sources/list.md Outdated Show resolved Hide resolved
internal/sdkv2provider/data_source_list.go Outdated Show resolved Hide resolved
internal/sdkv2provider/data_source_lists.go Outdated Show resolved Hide resolved
internal/sdkv2provider/data_source_lists.go Outdated Show resolved Hide resolved
internal/sdkv2provider/data_source_lists.go Show resolved Hide resolved
internal/sdkv2provider/provider.go Outdated Show resolved Hide resolved
@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^(TestAccCloudflareListDataSource|TestAccCloudflareListsDataSource)" -timeout 120m -parallel 1
=== RUN   TestAccCloudflareListDataSource
--- PASS: TestAccCloudflareListDataSource (22.99s)
=== RUN   TestAccCloudflareListsDataSource
--- PASS: TestAccCloudflareListsDataSource (16.78s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	40.700s

thanks for this one @rwhelan 🙇

@jacobbednarz jacobbednarz merged commit c324c52 into cloudflare:master Mar 20, 2023
@github-actions github-actions bot added this to the v4.2.0 milestone Mar 20, 2023
github-actions bot pushed a commit that referenced this pull request Mar 20, 2023
rwhelan pushed a commit to rwhelan/terraform-provider-cloudflare that referenced this pull request Mar 20, 2023
@github-actions
Copy link

This functionality has been released in v4.2.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
@rwhelan rwhelan deleted the data_source_list branch March 24, 2023 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants