Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional config_src parameter to cloudflare_tunnel resource #2369

Merged
merged 3 commits into from
Apr 18, 2023

Conversation

obezuk
Copy link
Contributor

@obezuk obezuk commented Apr 12, 2023

Adds config_src (described here in API Docs) parameter to cloudflare_tunnel resource.

This enables developers to provision manageable Tunnels in Terraform which can be further managed by other resource types such as cloudflare_tunnel_route.

@obezuk obezuk requested a review from jacobbednarz as a code owner April 12, 2023 03:08
@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2023

changelog detected ✅

@obezuk obezuk force-pushed the tunnel-add-config-src-param branch from 35a1545 to ae06159 Compare April 12, 2023 03:15
@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareTunnel" -timeout 120m -parallel 1
=== RUN   TestAccCloudflareTunnelConfig_Full
--- PASS: TestAccCloudflareTunnelConfig_Full (18.98s)
=== RUN   TestAccCloudflareTunnelConfig_Short
--- PASS: TestAccCloudflareTunnelConfig_Short (18.58s)
=== RUN   TestAccCloudflareTunnelRoute_Exists
--- PASS: TestAccCloudflareTunnelRoute_Exists (17.05s)
=== RUN   TestAccCloudflareTunnelRoute_UpdateComment
--- PASS: TestAccCloudflareTunnelRoute_UpdateComment (23.89s)
=== RUN   TestAccCloudflareTunnelCreate_Basic
--- PASS: TestAccCloudflareTunnelCreate_Basic (12.25s)
=== RUN   TestAccCloudflareTunnelCreate_Managed
--- PASS: TestAccCloudflareTunnelCreate_Managed (13.43s)
=== RUN   TestAccCloudflareTunnelCreate_Unmanaged
--- PASS: TestAccCloudflareTunnelCreate_Unmanaged (12.43s)
=== RUN   TestAccCloudflareTunnelVirtualNetwork_Exists
--- PASS: TestAccCloudflareTunnelVirtualNetwork_Exists (11.48s)
=== RUN   TestAccCloudflareTunnelVirtualNetwork_UpdateComment
--- PASS: TestAccCloudflareTunnelVirtualNetwork_UpdateComment (20.66s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	149.177s

@jacobbednarz jacobbednarz force-pushed the tunnel-add-config-src-param branch from 2c66048 to 1650f7a Compare April 12, 2023 03:28
@jacobbednarz jacobbednarz force-pushed the tunnel-add-config-src-param branch from 1650f7a to 8fbcdec Compare April 12, 2023 03:41
@jacobbednarz jacobbednarz merged commit b138485 into cloudflare:master Apr 18, 2023
@github-actions github-actions bot added this to the v4.4.0 milestone Apr 18, 2023
github-actions bot pushed a commit that referenced this pull request Apr 18, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v4.4.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants