Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for turnstile / challenge widgets #2380

Merged
merged 14 commits into from
Apr 26, 2023
Merged

Add support for turnstile / challenge widgets #2380

merged 14 commits into from
Apr 26, 2023

Conversation

Cyb3r-Jak3
Copy link
Contributor

@Cyb3r-Jak3 Cyb3r-Jak3 commented Apr 15, 2023 •
edited by jacobbednarz
Loading

Adds support for turnstile / challenge widgets

Needs cloudflare/cloudflare-go#1267

Closes #2273

@github-actions
Copy link
Contributor

changelog detected ✅

@Cyb3r-Jak3 Cyb3r-Jak3 marked this pull request as draft April 15, 2023 20:28
@Cyb3r-Jak3 Cyb3r-Jak3 marked this pull request as ready for review April 17, 2023 21:44
punkeel
punkeel reviewed Apr 17, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
internal/framework/service/turnstile/model.go Outdated Show resolved Hide resolved
@Cyb3r-Jak3 Cyb3r-Jak3 mentioned this pull request Apr 18, 2023
Closed
jacobbednarz
jacobbednarz reviewed Apr 18, 2023
View reviewed changes
go.sum Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz added the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Apr 18, 2023
@jacobbednarz
Copy link
Member

acceptance tests are passing

TF_ACC=1 go test ./internal/framework/service/turnstile -v -count 1 -run ^TestAccCloudflareTurnstileWidget_ -timeout 120m -parallel 1
=== RUN   TestAccCloudflareTurnstileWidget_Basic
=== PAUSE TestAccCloudflareTurnstileWidget_Basic
=== CONT  TestAccCloudflareTurnstileWidget_Basic
--- PASS: TestAccCloudflareTurnstileWidget_Basic (21.04s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/turnstile	22.027s

jacobbednarz
jacobbednarz reviewed Apr 26, 2023
View reviewed changes
.changelog/2380.txt Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit 1134fe2 into cloudflare:master Apr 26, 2023
@github-actions github-actions bot added this to the v4.5.0 milestone Apr 26, 2023
github-actions bot pushed a commit that referenced this pull request Apr 26, 2023
Update CHANGELOG.md for #2380
3db3162
@punkeel
Copy link
Member

punkeel commented Apr 26, 2023

That's great! Thank you both 🙏

@Cyb3r-Jak3 Cyb3r-Jak3 deleted the turnstile branch April 26, 2023 21:41
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

This functionality has been released in v4.5.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@punkeel punkeel punkeel left review comments

@jacobbednarz jacobbednarz jacobbednarz left review comments

Assignees
No one assigned
Labels
workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library.
Projects
None yet
Milestone
v4.5.0
Development

Successfully merging this pull request may close these issues.

Turnstile sites
3 participants
@Cyb3r-Jak3 @jacobbednarz @punkeel