resource/cloudflare_certificate_pack: handle deletion via UI #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deletion policy for certificate packs is a little different and for a short period of time following deletion, the URL does not return a 404 like most other resources. Instead, it will return a HTTP 200 with the `status` field set to deleted. This isn't standard handling so we'll explicitly account for both of these scenarios.
|
changelog detected ✅ |
|
acceptance tests all passing |
|
This functionality has been released in v4.8.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deletion policy for certificate packs is a little different and for a short period of time following deletion, the URL does not return a 404 like most other resources. Instead, it will return a HTTP 200 with the
statusfield set to deleted. This isn't standard handling so we'll explicitly account for both of these scenarios.Closes #2461