Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add import for cloudflare_user_agent_blocking_rule #2640

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Add import for cloudflare_user_agent_blocking_rule #2640

merged 4 commits into from
Jul 31, 2023

Conversation

Nmishin
Copy link

@Nmishin Nmishin commented Jul 30, 2023 •
edited by jacobbednarz
Loading

Fixes #2630

@Nmishin Nmishin requested a review from jacobbednarz as a code owner July 30, 2023 16:33
@github-actions
Copy link

changelog detected ✅

@Nmishin
Copy link
Author

Nmishin commented Jul 30, 2023

Fix for #2630

@jacobbednarz
Copy link
Member

@Nmishin i went ahead and added a test case for the Import operations you've added here. in future, it would be great if we can add these to accompany the code changes.

other than that small thing, thank you! this looks good.

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareUserAgentBlockingRule_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareUserAgentBlockingRule_Basic
--- PASS: TestAccCloudflareUserAgentBlockingRule_Basic (17.18s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	17.858s

@jacobbednarz jacobbednarz merged commit 873df52 into cloudflare:master Jul 31, 2023
@github-actions github-actions bot added this to the v4.12.0 milestone Jul 31, 2023
github-actions bot pushed a commit that referenced this pull request Jul 31, 2023
Update CHANGELOG.md for #2640
d5886e9
@nial-perlego
Copy link

Thanks guys! @Nmishin @jacobbednarz

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

This functionality has been released in v4.12.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbednarz jacobbednarz Awaiting requested review from jacobbednarz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.12.0
Development

Successfully merging this pull request may close these issues.

import support for the cloudflare_user_agent_blocking_rule resource
3 participants
@Nmishin @jacobbednarz @nial-perlego