-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non_identity_browser_isolation_enabled field in Browser Isolation… #2878
Add non_identity_browser_isolation_enabled field in Browser Isolation… #2878
Conversation
This project handles dependency version bumps (including upstream changes from cloudflare-go) independently of the standard PR process using automation. This allows the dependency upgrades to land without causing merge conflicts in multiple branches and handled in a consistent way. The exception to this is security related dependency upgrades but they should be co-ordinated with the maintainer team privately. Please remove the changes to the |
@jacobbednarz i'm not used to modifying the terraform provider, I have no idea if this constitutes a complete change or if something else is needed. |
changelog detected ✅ |
yep, we want a changelog here. however, as the automation mentions, we want to remove the version bump commit. we have automation that handles that outside of PRs to prevent merge conflict hell. |
6cc70e7
to
9c62692
Compare
… settings - handle SDK breaking change: url_browser_isolation_enabled bool -> *bool - add non_identity_browser_isolation_enabled
9c62692
to
fee208b
Compare
I've removed the version bump, I'm assuming the unit test will succeed when rebased on a commit that includes the version bump. |
if you want to test out your changes you can use the local development guides to have the two non-released versions (sdk and provider) running together. once you have your tests setup, you can run the acceptance test suite (careful, this creates and manages real resources) using the docs. |
acceptance tests all looking good
|
This functionality has been released in v4.18.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
… settings