Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AUTH-5670 added common_names to access groups to support multiple com… #3229

Merged
merged 3 commits into from
Apr 9, 2024
Merged

AUTH-5670 added common_names to access groups to support multiple com… #3229

merged 3 commits into from
Apr 9, 2024

Conversation

russellkerns
Copy link

adds the common_names field to access groups to support multiple common_name rules within the same policy block

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024 •
edited
Loading

changelog detected ✅

@jacobbednarz
Copy link
Member

looks like the acceptance tests are failing at the moment too

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareAccessGroup_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareAccessGroup_ConfigBasicZone
--- PASS: TestAccCloudflareAccessGroup_ConfigBasicZone (18.41s)
=== RUN   TestAccCloudflareAccessGroup_ConfigBasicAccount
--- PASS: TestAccCloudflareAccessGroup_ConfigBasicAccount (13.01s)
=== RUN   TestAccCloudflareAccessGroup_Exclude
--- PASS: TestAccCloudflareAccessGroup_Exclude (14.48s)
=== RUN   TestAccCloudflareAccessGroup_Require
--- PASS: TestAccCloudflareAccessGroup_Require (7.88s)
=== RUN   TestAccCloudflareAccessGroup_FullConfig
--- PASS: TestAccCloudflareAccessGroup_FullConfig (7.59s)
=== RUN   TestAccCloudflareAccessGroup_WithIDP
--- PASS: TestAccCloudflareAccessGroup_WithIDP (10.96s)
=== RUN   TestAccCloudflareAccessGroup_WithIDPAuthContext
--- PASS: TestAccCloudflareAccessGroup_WithIDPAuthContext (9.78s)
=== RUN   TestAccCloudflareAccessGroup_Updated
--- PASS: TestAccCloudflareAccessGroup_Updated (20.92s)
=== RUN   TestAccCloudflareAccessGroup_CreateAfterManualDestroy
--- PASS: TestAccCloudflareAccessGroup_CreateAfterManualDestroy (14.63s)
=== RUN   TestAccCloudflareAccessGroup_UpdatedFromCommonNameToCommonNames
    resource_cloudflare_access_group_test.go:351: Step 2/2 error: Check failed: Check 3/5 error: cloudflare_access_group.dtxbemrooy: Attribute 'common_names.0' not found
--- FAIL: TestAccCloudflareAccessGroup_UpdatedFromCommonNameToCommonNames (20.04s)
FAIL
FAIL	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	138.415s
FAIL
make: *** [testacc] Error 1

@russellkerns
Copy link
Author

looks like the acceptance tests are failing at the moment too

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareAccessGroup_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareAccessGroup_ConfigBasicZone
--- PASS: TestAccCloudflareAccessGroup_ConfigBasicZone (18.41s)
=== RUN   TestAccCloudflareAccessGroup_ConfigBasicAccount
--- PASS: TestAccCloudflareAccessGroup_ConfigBasicAccount (13.01s)
=== RUN   TestAccCloudflareAccessGroup_Exclude
--- PASS: TestAccCloudflareAccessGroup_Exclude (14.48s)
=== RUN   TestAccCloudflareAccessGroup_Require
--- PASS: TestAccCloudflareAccessGroup_Require (7.88s)
=== RUN   TestAccCloudflareAccessGroup_FullConfig
--- PASS: TestAccCloudflareAccessGroup_FullConfig (7.59s)
=== RUN   TestAccCloudflareAccessGroup_WithIDP
--- PASS: TestAccCloudflareAccessGroup_WithIDP (10.96s)
=== RUN   TestAccCloudflareAccessGroup_WithIDPAuthContext
--- PASS: TestAccCloudflareAccessGroup_WithIDPAuthContext (9.78s)
=== RUN   TestAccCloudflareAccessGroup_Updated
--- PASS: TestAccCloudflareAccessGroup_Updated (20.92s)
=== RUN   TestAccCloudflareAccessGroup_CreateAfterManualDestroy
--- PASS: TestAccCloudflareAccessGroup_CreateAfterManualDestroy (14.63s)
=== RUN   TestAccCloudflareAccessGroup_UpdatedFromCommonNameToCommonNames
    resource_cloudflare_access_group_test.go:351: Step 2/2 error: Check failed: Check 3/5 error: cloudflare_access_group.dtxbemrooy: Attribute 'common_names.0' not found
--- FAIL: TestAccCloudflareAccessGroup_UpdatedFromCommonNameToCommonNames (20.04s)
FAIL
FAIL	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	138.415s
FAIL
make: *** [testacc] Error 1

Should be fixed now

@jacobbednarz
Copy link
Member

lgtm!

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^TestAccCloudflareAccessGroup_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareAccessGroup_ConfigBasicZone
--- PASS: TestAccCloudflareAccessGroup_ConfigBasicZone (17.62s)
=== RUN   TestAccCloudflareAccessGroup_ConfigBasicAccount
--- PASS: TestAccCloudflareAccessGroup_ConfigBasicAccount (17.13s)
=== RUN   TestAccCloudflareAccessGroup_Exclude
--- PASS: TestAccCloudflareAccessGroup_Exclude (8.16s)
=== RUN   TestAccCloudflareAccessGroup_Require
--- PASS: TestAccCloudflareAccessGroup_Require (8.44s)
=== RUN   TestAccCloudflareAccessGroup_FullConfig
--- PASS: TestAccCloudflareAccessGroup_FullConfig (8.75s)
=== RUN   TestAccCloudflareAccessGroup_WithIDP
--- PASS: TestAccCloudflareAccessGroup_WithIDP (10.28s)
=== RUN   TestAccCloudflareAccessGroup_WithIDPAuthContext
--- PASS: TestAccCloudflareAccessGroup_WithIDPAuthContext (9.21s)
=== RUN   TestAccCloudflareAccessGroup_Updated
--- PASS: TestAccCloudflareAccessGroup_Updated (13.29s)
=== RUN   TestAccCloudflareAccessGroup_CreateAfterManualDestroy
--- PASS: TestAccCloudflareAccessGroup_CreateAfterManualDestroy (14.28s)
=== RUN   TestAccCloudflareAccessGroup_UpdatedFromCommonNameToCommonNames
--- PASS: TestAccCloudflareAccessGroup_UpdatedFromCommonNameToCommonNames (13.68s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	124.608s

@jacobbednarz jacobbednarz merged commit dd78659 into cloudflare:master Apr 9, 2024
9 checks passed
@github-actions github-actions bot added this to the v4.30.0 milestone Apr 9, 2024
github-actions bot pushed a commit that referenced this pull request Apr 9, 2024
Update CHANGELOG.md for #3229
587e70b
@github-actions GitHub Actions
Copy link

This functionality has been released in v4.30.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbednarz jacobbednarz jacobbednarz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.30.0
Development

Successfully merging this pull request may close these issues.
3 participants
@russellkerns @jacobbednarz @rkernscloudflaretest