Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPEED-836: Deprecate Auto Minify settings #3521

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

aseure
Copy link
Member

@aseure aseure commented Jul 30, 2024

This commit deprecates the settings for the Auto Minify feature whose sunset date is set to August 8th, 2024.

After this date, it will not be able for the users of the Cloudflare dashboard, Terraform provider to change that setting.

Automatic migration of user configuration can be handled with Grit:

grit apply \
  github.com/cloudflare/terraform-provider-cloudflare#cloudflare_zone_settings_override_remove_minify

Copy link
Contributor

github-actions bot commented Jul 30, 2024

changelog detected ✅

@aseure aseure force-pushed the aseure/SPEED-836 branch 2 times, most recently from b3a73d0 to a6841d5 Compare July 30, 2024 13:20
This commit deprecates the settings for the Auto Minify feature whose
sunset date is set to August 8th, 2024.

After this date, it will not be able for the users of the Cloudflare
dashboard, Terraform provider to change that setting.
@jacobbednarz
Copy link
Member

acceptance tests all passing

TF_ACC=1 go test ./internal/sdkv2provider -v -run "^(TestAccCloudflareZoneSettingsOverride|TestCloudflareZoneSettingsOverride)" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareZoneSettingsOverride_Full
--- PASS: TestAccCloudflareZoneSettingsOverride_Full (33.47s)
=== RUN   TestAccCloudflareZoneSettingsOverride_RemoveAttributes
--- PASS: TestAccCloudflareZoneSettingsOverride_RemoveAttributes (36.05s)
=== RUN   TestAccCloudflareZoneSettingsOverride_NEL
--- PASS: TestAccCloudflareZoneSettingsOverride_NEL (11.03s)
=== RUN   TestCloudflareZoneSettingsOverrideStateUpgradeV0
--- PASS: TestCloudflareZoneSettingsOverrideStateUpgradeV0 (0.00s)
=== RUN   TestCloudflareZoneSettingsOverrideStateUpgradeV1
--- PASS: TestCloudflareZoneSettingsOverrideStateUpgradeV1 (0.00s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/sdkv2provider	81.657s

@jacobbednarz jacobbednarz merged commit 564e587 into cloudflare:master Aug 1, 2024
8 checks passed
@github-actions github-actions bot added this to the v4.39.0 milestone Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 7, 2024

This functionality has been released in v4.39.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants