Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zone Settings Override resource (updated) #41

Merged
merged 15 commits into from
Mar 22, 2018

Conversation

benjvi
Copy link
Contributor

@benjvi benjvi commented Mar 18, 2018

Continued from #35. Reopening this so others can address issues identified there in the next few days

@benjvi benjvi changed the title Zone Settings Override resource Zone Settings Override resource (updated) Mar 18, 2018
@nickithewatt
Copy link

@catsby, @benjvi answered some of your original review comments in #35, however there are still a few outstanding review items to address in this PR - we will get onto those this week.

@benjvi
Copy link
Contributor Author

benjvi commented Mar 22, 2018

Hopefully, all the comments from the previous review are now addressed. I had to make quite a few changes to get this to work in free plans as well, which included a fair amount of cleanup - so it should be a bit more understandable now as well. Let me know what you think @catsby

Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@catsby catsby merged commit 97b038f into cloudflare:master Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants