resource/cloudflare_zone: Add unicode support #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
jacobbednarz
force-pushed
the
non-unicode-domain-support
branch
from
a3b16ed to
44b372c
Compare
jacobbednarz
force-pushed
the
non-unicode-domain-support
branch
from
795e99c to
37454bd
Compare
jacobbednarz
commented
Jul 16, 2019
| Providers: testAccProviders, | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: testZoneConfig("tf-acc-unicode-test-1", "zajęzyk.pl", "true", "false"), |
There was a problem hiding this comment.
This domain needs to be swapped out with our own domain before merging.
Introduce unicode support for using zone names and ensure that the schema comparison is performed after first converting both values to unicode. This change ensures that the punycode and unicode values are both stored as the unicode version to match what the Cloudflare API returns. Closes cloudflare#399
jacobbednarz
force-pushed
the
non-unicode-domain-support
branch
from
9e7c741 to
068eefb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce unicode support for using zone names and ensure that the
schema comparison is performed after first converting both values to
unicode. This change ensures that the punycode and unicode values are
both stored as the unicode version to match what the Cloudflare API
returns.
To do
Closes #399