Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/cloudflare_zone_override: Remove sha1_support #415

Merged

Conversation

jacobbednarz
Copy link
Member

Cloudflare no longer offer SHA1 certificates once the existing ones
expire and this API endpoint has been removed which ends up erroring
when zone updates are applied.

Fixes the following error:

$ terraform apply
cloudflare_zone_settings_override.example_net: Refreshing state... (ID: 2bed060c895c6308651318210a2ef4a2)

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  ~ cloudflare_zone_settings_override.example_net
      settings.0.sha1_support:    "" => "on"

Plan: 0 to add, 1 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

cloudflare_zone_settings_override.example_net: Modifying... (ID: 2bed060c895c6308651318210a2ef4a2)
  settings.0.sha1_support:    "" => "on"

Error: Error applying plan:

1 error occurred:
    * cloudflare_zone_settings_override.example_net: 1 error occurred:
    * cloudflare_zone_settings_override.example_net: error from makeRequest: HTTP status 400: content "{\"success\":false,\"errors\":[{\"code\":1006,\"message\":\"Unrecognized zone setting name\"}],\"messages\":[],\"result\":null}"

Cloudflare no longer offer SHA1 certificates once the existing ones
expire and this API endpoint has been removed which ends up erroring
when zone updates are applied.

Fixes the following error:

```
$ terraform apply
cloudflare_zone_settings_override.example_net: Refreshing state... (ID: 2bed060c895c6308651318210a2ef4a2)

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  ~ cloudflare_zone_settings_override.example_net
      settings.0.sha1_support:    "" => "on"

Plan: 0 to add, 1 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

cloudflare_zone_settings_override.example_net: Modifying... (ID: 2bed060c895c6308651318210a2ef4a2)
  settings.0.sha1_support:    "" => "on"

Error: Error applying plan:

1 error occurred:
    * cloudflare_zone_settings_override.example_net: 1 error occurred:
    * cloudflare_zone_settings_override.example_net: error from makeRequest: HTTP status 400: content "{\"success\":false,\"errors\":[{\"code\":1006,\"message\":\"Unrecognized zone setting name\"}],\"messages\":[],\"result\":null}"
```
@ghost ghost added size/XS kind/documentation Categorizes issue or PR as related to documentation. labels Jul 16, 2019
@jacobbednarz jacobbednarz merged commit 28ca548 into cloudflare:master Jul 16, 2019
@jacobbednarz jacobbednarz deleted the remove-zone-setting-sha1-support branch July 16, 2019 22:23
boekkooi-lengoo pushed a commit to boekkooi-lengoo/terraform-provider-cloudflare that referenced this pull request Feb 28, 2022
* auditlogs: fix GetOrganizationAuditLogs()

Move to using stdlib strategies for encoding URL parameters.

* Fix tests

* Update godoc

* auditlogs: use /accounts/${account_id}/audit_logs for audit logs

`/organizations` has been deprecated.

Pointed out by: @jacobbednarz

* Update auditlogs_test.go

Co-authored-by: Patryk Szczygłowski <patryk@patryk.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant