Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long Cloudflare List resources refresh time increased greatly by 4.44 #4293

Open
3 tasks done
upstart-swiss opened this issue Oct 16, 2024 · 5 comments
Open
3 tasks done
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@upstart-swiss
Copy link

Confirmation

  • This is a bug with an existing resource and is not a feature request or enhancement. Feature requests should be submitted with Cloudflare Support or your account team.
  • I have searched the issue tracker and my issue isn't already found.
  • I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version

Terraform 1.6.1
Cloudflare 4.44 vs 4.43

Affected resource(s)

cloudflare_list

Terraform configuration files

resource "cloudflare_list" "investor_ips" {
  name        = "investor_ip_list"
  account_id  = var.account_id
  kind        = "ip"
  description = "A list of Investor IPs, managed by Terraform"

  dynamic "item" {
    for_each = var.investor_ips
    content {
      value { ip = item.value }
    }
  }
}

(var.investor_ips is a 2k long list)

Link to debug output

Cannot safely share

Panic output

No response

Expected output

Builds in 4 minutes in v4.43

Actual output

Takes 13 minutes in v4.44

Steps to reproduce

Create a long IP list
tf apply
run a tf plan in 4.43 vs 4.44

Additional factoids

No response

References

No response

@upstart-swiss upstart-swiss added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 16, 2024
Copy link
Contributor

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

Copy link
Contributor

Thank you for reporting this issue! For maintainers to dig into issues it is required that all issues include the entirety of TF_LOG=DEBUG output to be provided. The only parts that should be redacted are your user credentials in the X-Auth-Key, X-Auth-Email and Authorization HTTP headers. Details such as zone or account identifiers are not considered sensitive but can be redacted if you are very cautious. This log file provides additional context from Terraform, the provider and the Cloudflare API that helps in debugging issues. Without it, maintainers are very limited in what they can do and may hamper diagnosis efforts.

This issue has been marked with triage/needs-information and is unlikely to receive maintainer attention until the log file is provided making this a complete bug report.

@github-actions github-actions bot added triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 16, 2024
@upstart-swiss
Copy link
Author

I cannot provide the log file that has all of our partner IPs in it, unfortunately. Happy to share that in an official cloudflare support ticket

@thedoc31
Copy link

I have the same problem in 4.43 with bulk redirect lists. We have one with 5800 rules and a second with 1800. I can't even get 4.44 or 4.45 to start scanning resources with a terraform plan. At least 4.43 allows me to get through, if I wait long enough. The 5800 rule list takes 7-10 minutes to parse through and the 1800 rule list takes 90 seconds.

@troymjones
Copy link
Contributor

We have the same issue and have several very long lists. Since upgrading to 4.47, our plans are now 4 times as long from 7-8 minutes to 30-40 minutes. We are unable to share our IP list as well. Let me know if it is required for someone to reproduce with a very long test list in a test account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

No branches or pull requests

3 participants