Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Workers KV Namespaces #443

Merged
merged 11 commits into from
Nov 28, 2019

Conversation

ashnewmanjones
Copy link
Contributor

Implemented Workers KV Namespace

Tested with Terraform v0.12.6

provider "cloudflare" {
  email = "${var.cloudflare_email}"
  token = "${var.cloudflare_token}"
  org_id = "${var.cloudflare_org}"
}

resource "cloudflare_workers_kv_namespace" "namespace" {
  title = "example"
}

This is my first contribution to an OSS Go project so I apologise for any non-idiomatic code, more than happy to fix any suggestions.

@ghost ghost added size/L kind/documentation Categorizes issue or PR as related to documentation. labels Aug 14, 2019
@eidam
Copy link

eidam commented Oct 27, 2019

can this be merged? :)

@jimsorock
Copy link

@eidam
Copy link

eidam commented Oct 29, 2019

Would this also close #277 ?

It will not, this one only adds the cloudflare_workers_kv_namespace resource

@eidam
Copy link

eidam commented Nov 25, 2019

@jacobbednarz do you think this can be merged? we have another MR to create for the KV namespace binding in cloudflare_worker resource and the cloudflare_workers_kv_namespace resource is needed in order to have tests passing :)

@patryk
Copy link
Contributor

patryk commented Nov 28, 2019

Looking good. Thanks!

@patryk patryk merged commit 26e6937 into cloudflare:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants